Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reports] update vizes for feature parity with legacy functionality #1295

Open
jhmullen opened this issue Dec 1, 2021 · 0 comments
Open
Assignees
Milestone

Comments

@jhmullen
Copy link
Collaborator

jhmullen commented Dec 1, 2021

Vizes are Really Complicated.

They make use of context quite a bit for d3plus configs, as well as various onClick callbacks for the legacy front-end. Further, the Options.jsx component digs into its configs and extracts out the data for download. Further further, there is a screenshot service which creates a mirror object to grab a png.

I have finished porting the rudimentary pieces of a Viz from a legacy component to a functional component. However, a number of the more nuanced pieces will need to be reviewed and re-implemented. I'm glad to talk through each of their purposes. This is related to #1323

@jhmullen jhmullen added this to the CMS 1.0 milestone Dec 1, 2021
@jhmullen jhmullen self-assigned this Dec 1, 2021
@jhmullen jhmullen changed the title [reports] make vizes display in blockcard [reports] update vizes for feature parity with legacy functionality Dec 17, 2021
@jhmullen jhmullen assigned greenrhyno and unassigned jhmullen Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants