Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the official version of ckanext-saml2 #116

Open
1 task
avdata99 opened this issue Feb 26, 2020 · 3 comments
Open
1 task

Define the official version of ckanext-saml2 #116

avdata99 opened this issue Feb 26, 2020 · 3 comments

Comments

@avdata99
Copy link

OKF also have a version

image

OKF created a 0.4 version wich also adds support for CKAN 2.8.

Task

  • Analyze OKF code and use it if is useful here. Otherwise, ask OKF to close its fork and reference this one as the oficial
@amercader
Copy link

"Official" is a loaded word that carries implications of support for the wider community, which is the reason why neither Link's or OKF's forks are in the main ckan GitHub org. To make an extension official at the very least it should have tests, which neither fork do AFAIA and to be honest a good internal refactoring wouldn't do harm. If Datopian has the capacity to tackle that it would be awesome to see.

Here are the changes we have added over time in our fork: link-master...okfn:link-master. Some of it is opinionated but most stuff I think is valuable, so happy to help port it where it makes sense.

@starsinmypockets
Copy link

Maybe instead of saying "official" we can say "canonical" for now which would reduce duplication in effort?

@starsinmypockets
Copy link

The idea being to deprecate one of the repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants