Skip to content

Latest commit

 

History

History
76 lines (57 loc) · 2.47 KB

CONTRIBUTING.md

File metadata and controls

76 lines (57 loc) · 2.47 KB
Raw

How to become a contributor and submit your own code

Table of contents

Contributor License Agreements

We'd love to accept your sample apps and patches! Before we can take them, we have to jump a couple of legal hurdles.

Please fill out either the individual or corporate Contributor License Agreement (CLA).

  • If you are an individual writing original source code and you're sure you own the intellectual property, then you'll need to sign an individual CLA.
  • If you work for a company that wants to allow you to contribute your work, then you'll need to sign a corporate CLA.

Follow either of the two links above to access the appropriate CLA and instructions for how to sign and return it. Once we receive it, we'll be able to accept your pull requests.

Contributing A Patch

  1. Submit an issue describing your proposed change to the repo in question.
  2. The repo owner will respond to your issue promptly.
  3. If your proposed change is accepted, and you haven't already done so, sign a Contributor License Agreement (see details above).
  4. Fork the desired repo, develop and test your code changes.
  5. Ensure that your code adheres to the existing style in the code to which you are contributing.
  6. Ensure that your code has an appropriate set of tests which all pass.
  7. Submit a pull request.

Running the tests

  1. Prepare your environment for Node.js setup.

  2. Install dependencies:

    npm install

  3. Run the tests:

    npm test

  4. Lint (and maybe fix) any changes:

    npm run fix

Running the system test

The system test starts a simple benchmark, uses this module to collect a time and a heap profile, and verifies that the profiles contain functions from within the benchmark.

To run the system test, golang must be installed.

The following command can be used to run the system test with all supported versions of Node.JS:

sh system-test/system_test.sh

To run the system test with the v8 canary build, use:

RUN_ONLY_V8_CANARY_TEST=true sh system-test/system_test.sh