Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Fix CrashtrackerReceiverConfig: its allowed to have empty log filenames #762

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Nov 26, 2024

What does this PR do?

Fixes a regression introduced by #722

Motivation

regressions are bad.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Additional unit test

@danielsn danielsn requested a review from a team as a code owner November 26, 2024 18:11
@danielsn danielsn force-pushed the dsn/crashtracker-fix-receiver-config branch from ef0706c to a2ca967 Compare November 26, 2024 18:14
@danielsn danielsn enabled auto-merge (squash) November 26, 2024 18:21
@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-26 18:25:16

Comparing candidate commit a2ca967 in PR branch dsn/crashtracker-fix-receiver-config with baseline commit eea04c6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 262.792µs 264.295µs ± 0.681µs 264.590µs ± 0.218µs 264.761µs 264.952µs 265.118µs 265.224µs 0.24% -1.033 -0.429 0.26% 0.048µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3770391.218op/s 3783671.273op/s ± 9777.566op/s 3779436.139op/s ± 3116.607op/s 3787501.329op/s 3803294.038op/s 3805108.145op/s 3805289.428op/s 0.68% 1.037 -0.422 0.26% 691.378op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 24.125µs 24.209µs ± 0.041µs 24.202µs ± 0.027µs 24.231µs 24.294µs 24.324µs 24.334µs 0.54% 0.836 0.336 0.17% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 41094564.945op/s 41307133.783op/s ± 70100.499op/s 41318293.975op/s ± 45728.932op/s 41360528.263op/s 41392998.582op/s 41428606.909op/s 41451058.359op/s 0.32% -0.828 0.320 0.17% 4956.854op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 14.506µs 14.546µs ± 0.072µs 14.511µs ± 0.002µs 14.544µs 14.717µs 14.835µs 14.858µs 2.39% 2.233 4.640 0.49% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 67305908.638op/s 68747254.107op/s ± 336896.473op/s 68913643.641op/s ± 10484.343op/s 68921434.188op/s 68930209.592op/s 68936398.909op/s 68939116.671op/s 0.04% -2.209 4.493 0.49% 23822.178op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [264.201µs; 264.390µs] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3782316.196op/s; 3785026.349op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [24.203µs; 24.215µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [41297418.528op/s; 41316849.038op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/good execution_time [14.536µs; 14.556µs] or [-0.069%; +0.069%] None None None
normalization/normalize_name/normalize_name/good throughput [68700563.496op/s; 68793944.718op/s] or [-0.068%; +0.068%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.618µs 4.630µs ± 0.007µs 4.629µs ± 0.004µs 4.633µs 4.640µs 4.642µs 4.691µs 1.34% 3.420 27.466 0.15% 0.000µs 1 200
credit_card/is_card_number/ throughput 213168425.240op/s 215987790.369op/s ± 325174.916op/s 216020379.098op/s ± 189627.649op/s 216209129.433op/s 216375569.327op/s 216522227.127op/s 216563328.296op/s 0.25% -3.341 26.571 0.15% 22993.339op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.383µs 91.057µs ± 0.428µs 91.021µs ± 0.171µs 91.191µs 91.462µs 91.645µs 96.006µs 5.48% 7.781 87.804 0.47% 0.030µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10416060.050op/s 10982329.542op/s ± 49812.782op/s 10986502.532op/s ± 20565.472op/s 11006755.408op/s 11028922.419op/s 11045953.919op/s 11064070.928op/s 0.71% -7.376 81.680 0.45% 3522.296op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.986µs 84.683µs ± 0.411µs 84.697µs ± 0.102µs 84.785µs 84.891µs 85.071µs 89.795µs 6.02% 9.569 118.521 0.48% 0.029µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11136431.676op/s 11809035.610op/s ± 54792.033op/s 11806767.278op/s ± 14190.728op/s 11826143.957op/s 11860851.919op/s 11901768.175op/s 11906764.233op/s 0.85% -9.148 111.982 0.46% 3874.382op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.611µs 4.629µs ± 0.007µs 4.628µs ± 0.004µs 4.632µs 4.637µs 4.642µs 4.693µs 1.40% 4.030 35.842 0.15% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 213069932.490op/s 216043271.499op/s ± 322082.671op/s 216057933.521op/s ± 175655.592op/s 216232842.647op/s 216415803.789op/s 216508196.626op/s 216891066.788op/s 0.39% -3.934 34.711 0.15% 22774.684op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 79.486µs 80.358µs ± 0.343µs 80.367µs ± 0.231µs 80.580µs 80.887µs 81.036µs 81.134µs 0.95% -0.203 -0.391 0.43% 0.024µs 1 200
credit_card/is_card_number/378282246310005 throughput 12325286.597op/s 12444483.076op/s ± 53144.807op/s 12442924.934op/s ± 35795.533op/s 12479001.050op/s 12531839.914op/s 12568531.637op/s 12580909.084op/s 1.11% 0.223 -0.379 0.43% 3757.905op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.949µs 60.130µs ± 0.075µs 60.114µs ± 0.051µs 60.182µs 60.266µs 60.315µs 60.339µs 0.37% 0.483 -0.225 0.12% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16573134.314op/s 16630635.138op/s ± 20632.361op/s 16634944.892op/s ± 14010.372op/s 16645126.431op/s 16658799.877op/s 16667054.336op/s 16680773.740op/s 0.28% -0.477 -0.232 0.12% 1458.928op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 7.637µs 7.649µs ± 0.004µs 7.649µs ± 0.002µs 7.651µs 7.655µs 7.658µs 7.661µs 0.17% 0.084 0.992 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 130524449.834op/s 130742594.942op/s ± 61771.329op/s 130743270.495op/s ± 35000.695op/s 130776012.410op/s 130847779.075op/s 130886225.490op/s 130947643.468op/s 0.16% -0.080 0.990 0.05% 4367.893op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.618µs 4.630µs ± 0.005µs 4.630µs ± 0.004µs 4.634µs 4.638µs 4.641µs 4.643µs 0.29% 0.169 -0.531 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215373759.682op/s 215975740.345op/s ± 231819.203op/s 215989068.017op/s ± 175724.544op/s 216166260.398op/s 216321690.828op/s 216394012.189op/s 216549426.680op/s 0.26% -0.165 -0.533 0.11% 16392.093op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 74.514µs 74.864µs ± 0.109µs 74.875µs ± 0.048µs 74.913µs 74.972µs 75.007µs 75.936µs 1.42% 4.394 45.490 0.15% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13169043.941op/s 13357560.878op/s ± 19323.541op/s 13355601.307op/s ± 8623.511op/s 13366896.550op/s 13380648.038op/s 13400167.424op/s 13420322.394op/s 0.48% -4.273 44.088 0.14% 1366.381op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 67.136µs 67.435µs ± 0.100µs 67.435µs ± 0.068µs 67.506µs 67.605µs 67.662µs 67.687µs 0.37% -0.098 0.166 0.15% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14773966.249op/s 14829192.980op/s ± 21958.233op/s 14829001.706op/s ± 14960.001op/s 14842986.235op/s 14864598.769op/s 14881529.344op/s 14895159.073op/s 0.45% 0.107 0.171 0.15% 1552.682op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.616µs 4.629µs ± 0.005µs 4.630µs ± 0.004µs 4.633µs 4.637µs 4.640µs 4.642µs 0.26% -0.114 -0.468 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215445787.257op/s 216020690.968op/s ± 241408.959op/s 216004968.115op/s ± 173349.151op/s 216191632.427op/s 216424367.067op/s 216546109.227op/s 216626505.517op/s 0.29% 0.119 -0.467 0.11% 17070.191op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.670µs 62.841µs ± 0.085µs 62.830µs ± 0.054µs 62.896µs 62.994µs 63.048µs 63.214µs 0.61% 0.817 1.079 0.13% 0.006µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15819216.413op/s 15913185.199op/s ± 21461.701op/s 15915837.850op/s ± 13633.114op/s 15928680.528op/s 15941613.363op/s 15949550.205op/s 15956620.332op/s 0.26% -0.808 1.045 0.13% 1517.571op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 60.020µs 60.223µs ± 0.091µs 60.216µs ± 0.062µs 60.284µs 60.366µs 60.445µs 60.526µs 0.52% 0.299 -0.067 0.15% 0.006µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16521794.275op/s 16605035.876op/s ± 25067.572op/s 16606893.452op/s ± 17130.471op/s 16621858.979op/s 16644370.519op/s 16650741.876op/s 16661071.407op/s 0.33% -0.291 -0.079 0.15% 1772.545op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 7.639µs 7.648µs ± 0.003µs 7.647µs ± 0.002µs 7.650µs 7.654µs 7.656µs 7.657µs 0.12% 0.318 0.141 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 130607849.731op/s 130757750.173op/s ± 54229.812op/s 130761726.043op/s ± 36465.389op/s 130798083.808op/s 130833100.134op/s 130881157.837op/s 130902339.449op/s 0.11% -0.315 0.141 0.04% 3834.627op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.629µs; 4.631µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/ throughput [215942724.253op/s; 216032856.485op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [90.998µs; 91.117µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10975425.970op/s; 10989233.115op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [84.626µs; 84.740µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11801441.961op/s; 11816629.258op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631 execution_time [4.628µs; 4.630µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631 throughput [215998633.939op/s; 216087909.060op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.311µs; 80.406µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/378282246310005 throughput [12437117.717op/s; 12451848.435op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [60.120µs; 60.140µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16627775.692op/s; 16633494.585op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/x371413321323331 execution_time [7.648µs; 7.649µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [130734034.030op/s; 130751155.854op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.629µs; 4.631µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ throughput [215943612.433op/s; 216007868.257op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [74.849µs; 74.879µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13354882.822op/s; 13360238.935op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [67.421µs; 67.449µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [14826149.780op/s; 14832236.179op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.628µs; 4.630µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215987234.008op/s; 216054147.928op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.829µs; 62.853µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15910210.814op/s; 15916159.585op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [60.210µs; 60.235µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16601561.752op/s; 16608510.000op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [7.647µs; 7.648µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [130750234.443op/s; 130765265.904op/s] or [-0.006%; +0.006%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.033ms 9.071ms ± 0.020ms 9.068ms ± 0.009ms 9.076ms 9.096ms 9.157ms 9.186ms 1.30% 2.602 10.017 0.22% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.068ms; 9.073ms] or [-0.031%; +0.031%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.699µs 2.744µs ± 0.025µs 2.734µs ± 0.011µs 2.771µs 2.788µs 2.792µs 2.792µs 2.15% 0.656 -1.049 0.90% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.741µs; 2.748µs] or [-0.126%; +0.126%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.396µs 3.244µs ± 1.446µs 3.084µs ± 0.018µs 3.100µs 3.147µs 14.189µs 15.270µs 395.22% 7.555 57.140 44.45% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.044µs; 3.445µs] or [-6.176%; +6.176%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.735ms 58.997ms ± 0.152ms 58.959ms ± 0.072ms 59.063ms 59.278ms 59.549ms 59.683ms 1.23% 1.480 3.227 0.26% 0.011ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.976ms; 59.018ms] or [-0.036%; +0.036%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.752µs 142.599µs ± 0.302µs 142.568µs ± 0.128µs 142.711µs 143.100µs 143.490µs 144.476µs 1.34% 1.567 7.989 0.21% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.557µs; 142.641µs] or [-0.029%; +0.029%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 625.099µs 626.123µs ± 0.553µs 626.061µs ± 0.274µs 626.354µs 626.798µs 627.568µs 630.364µs 0.69% 3.291 20.840 0.09% 0.039µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1586384.290op/s 1597130.710op/s ± 1406.417op/s 1597287.896op/s ± 698.696op/s 1597954.299op/s 1598797.293op/s 1599056.745op/s 1599747.331op/s 0.15% -3.259 20.544 0.09% 99.449op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 467.833µs 468.917µs ± 0.379µs 468.922µs ± 0.226µs 469.142µs 469.560µs 469.785µs 469.951µs 0.22% -0.022 0.034 0.08% 0.027µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2127879.273op/s 2132573.779op/s ± 1724.748op/s 2132552.744op/s ± 1027.575op/s 2133593.856op/s 2135304.311op/s 2136450.139op/s 2137514.642op/s 0.23% 0.027 0.034 0.08% 121.958op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.948µs 179.493µs ± 0.464µs 179.420µs ± 0.232µs 179.615µs 180.562µs 181.483µs 181.650µs 1.24% 2.057 5.474 0.26% 0.033µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5505080.384op/s 5571290.783op/s ± 14340.425op/s 5573512.765op/s ± 7225.685op/s 5581448.979op/s 5585865.613op/s 5587725.865op/s 5588220.903op/s 0.26% -2.032 5.339 0.26% 1014.021op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.368µs 47.534µs ± 0.057µs 47.533µs ± 0.038µs 47.574µs 47.626µs 47.660µs 47.689µs 0.33% -0.112 -0.020 0.12% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20969350.149op/s 21037550.066op/s ± 25341.936op/s 21037925.601op/s ± 16881.876op/s 21054184.523op/s 21084142.703op/s 21096952.635op/s 21111442.025op/s 0.35% 0.119 -0.016 0.12% 1791.946op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.995µs 49.397µs ± 0.165µs 49.412µs ± 0.113µs 49.503µs 49.661µs 49.742µs 49.801µs 0.79% -0.187 -0.263 0.33% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20079769.770op/s 20244286.957op/s ± 67850.315op/s 20238064.779op/s ± 46347.907op/s 20290934.701op/s 20361878.798op/s 20400376.459op/s 20410317.768op/s 0.85% 0.204 -0.258 0.33% 4797.742op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [626.047µs; 626.200µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1596935.795op/s; 1597325.626op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.865µs; 468.970µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2132334.745op/s; 2132812.812op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [179.428µs; 179.557µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5569303.338op/s; 5573278.228op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.526µs; 47.542µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21034037.917op/s; 21041062.215op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.374µs; 49.420µs] or [-0.046%; +0.046%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20234883.556op/s; 20253690.358op/s] or [-0.046%; +0.046%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 277.342ns 287.537ns ± 12.972ns 282.705ns ± 3.942ns 290.270ns 319.283ns 335.819ns 338.074ns 19.59% 2.248 5.025 4.50% 0.917ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [285.739ns; 289.335ns] or [-0.625%; +0.625%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.647µs 23.831µs ± 12.014µs 18.803µs ± 0.061µs 18.986µs 38.439µs 47.678µs 125.779µs 568.92% 4.718 32.241 50.29% 0.850µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.166µs; 25.496µs] or [-6.987%; +6.987%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 74.581µs 74.748µs ± 0.210µs 74.718µs ± 0.038µs 74.759µs 74.871µs 75.209µs 77.072µs 3.15% 8.504 83.761 0.28% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [74.719µs; 74.777µs] or [-0.039%; +0.039%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a2ca967 1732644863 dsn/crashtracker-fix-receiver-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.679µs 39.237µs ± 0.960µs 38.782µs ± 0.041µs 38.992µs 41.223µs 41.286µs 43.485µs 12.12% 1.844 2.067 2.44% 0.068µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [39.104µs; 39.370µs] or [-0.339%; +0.339%] None None None

Baseline

Omitted due to size.

@danielsn danielsn merged commit 7f83b73 into main Nov 26, 2024
32 checks passed
@danielsn danielsn deleted the dsn/crashtracker-fix-receiver-config branch November 26, 2024 18:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (eea04c6) to head (a2ca967).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   70.48%   70.52%   +0.04%     
==========================================
  Files         297      297              
  Lines       43403    43479      +76     
==========================================
+ Hits        30594    30665      +71     
- Misses      12809    12814       +5     
Components Coverage Δ
crashtracker 44.79% <100.00%> (+1.34%) ⬆️
crashtracker-ffi 8.41% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 89.36% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.05% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.01% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.36% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.29% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants