Use a different tool to replay traces

DataDog · Apr 1, 2023 · cc90a11 · cc90a11
1 parent 7eda1f6
commit cc90a11
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/submit-traces.yml b/.github/workflows/submit-traces.yml
@@ -39,7 +39,7 @@ jobs:
         path: captured-traces
 
     - name: Set up trace replaying
-      run: pipx install mitmproxy
+      run: go install github.com/google/go-replayers/httpreplay/cmd/httpr@latest
 
     - name: Replay
       run: |-
@@ -49,7 +49,7 @@ jobs:
           # check classes like when testing ddev or the downloader
           if [[ -s "$request" ]]; then
             echo "/// Replaying: $request"
-            mitmdump -C "$request"
+            httpr -replay "$request"
           fi
         done
 

diff --git a/.github/workflows/test-target.yml b/.github/workflows/test-target.yml
@@ -160,9 +160,9 @@ jobs:
     - name: Set up trace capturing
       if: inputs.repo == 'core'
       run: |-
-        pipx install mitmproxy
+        go install github.com/google/go-replayers/httpreplay/cmd/httpr@latest
         mkdir .trace-captures
-        mitmdump -p "${{ inputs.trace-agent-port }}" -w "${{ env.TRACE_CAPTURE_FILE }}" > "${{ env.TRACE_CAPTURE_LOG }}" 2>&1 &
+        httpr -port "${{ inputs.trace-agent-port }}" -record "${{ env.TRACE_CAPTURE_FILE }}" > "${{ env.TRACE_CAPTURE_LOG }}" 2>&1 &
 
     - name: Run Unit & Integration tests
       if: inputs.standard && !inputs.minimum-base-package
@@ -204,8 +204,8 @@ jobs:
     - name: Save trace captures
       if: inputs.repo == 'core' && always()
       run: |-
-        Stop-Process -Name "*mitmdump*"
         cat "${{ env.TRACE_CAPTURE_LOG }}"
+        Stop-Process -Name "*httpr*"
       shell: "pwsh"
 
     - name: Upload captured traces

diff --git a/disk/pyproject.toml b/disk/pyproject.toml
@@ -6,6 +6,7 @@ requires = [
 ]
 build-backend = "hatchling.build"
 
+
 [project]
 name = "datadog-disk"
 description = "The Disk check"