Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Segfault in dd_observe_fiber_switch #2923

Open
cleverhoods opened this issue Nov 5, 2024 · 1 comment
Open

[Bug]: Segfault in dd_observe_fiber_switch #2923

cleverhoods opened this issue Nov 5, 2024 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@cleverhoods
Copy link

Bug report

dd_observe_fiber_switch function in /tmp/pear/temp/datadog_trace/ext/handlers_fiber.c:112 does not check for ZEND_FIBER_STATUS_DEAD thus it can lead to a Segmentation fault.

PHP version

8.1

Tracer or profiler version

0.99.1

Installed extensions

No response

Output of phpinfo()

No response

Upgrading from

No response

@cleverhoods cleverhoods added the 🐛 bug Something isn't working label Nov 5, 2024
@bwoebi
Copy link
Collaborator

bwoebi commented Nov 5, 2024

Hey @cleverhoods,

Are you able to reproduce that somehow? I've tried, but fail to. I'm also not sure what special handling would need to happen here, if the fiber is dead? I also don't quite know from your report where exactly the invalid pointer dereference for the segfault then will happen?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants