-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: upgrade from 1.3.2 to 1.4.* seems to cause segmentation fault when MongoDB Exception was thrown #2898
Comments
Hint: for a rapid search, find |
this is the strage behavior of the controller:
|
same. |
@bluezod Is it possible for you to open these core dumps with gdb and give us a backtrace? Like |
into my
with
I have never used gdb, so I don't know if this can be useful to you. |
Thanks for the response @bwoebi Here is the output I got following your debug instructions:
|
I am using Kubernetes, and when deploying the latest version, memory fills up in several pods sequentially within 10 minutes, causing OOM errors. The cause is unknown, but it does not occur in version 1.3.1 for now. |
@neoty We have observed (via our telemetry) that for some users the dd-ipc-helper process is using too much memory (but we do not know why yet). We do kill the process, once it reaches 1 GB of RSS memory used as a stop-gap measure, but maybe that's too much for you? |
@bluezod Looks like it's related to an dd-trace-php/appsec/src/helper/runner.cpp Line 148 in 3f3547d
|
Currently, due to stable operations and policies in place, additional testing is challenging (apologies for not being able to assist further). However, we do have the following information:
|
Thanks for reporting, I managed to reproduce the issue (which we saw in our crashtracking telemetry). I'll work on fixing it. |
They're shared across all inheritors on PHP 8.1+ and thus only need to be incremented on the specific ce. This issue arises when a property from an inherited internal class extending Exception is itself inherited by another class. Also fix an accidentally discovered use-after-free with peer.service. Fixes #2898. Signed-off-by: Bob Weinand <[email protected]>
@bluezod @mirkojoshua We've released 1.4.2 which will fixes both things. @neoty I suppose what you observe matches #2902. I'll track that there. |
@bwoebi (my prev tag was wrong :p) thank you! |
Bug report
Hello,
When i try to save a mongo document twice i expect a
MongoDb\Driver\Exception\BulkWriteException
with code11000
due to a violation of a unique index (in my case an email field). The exception is catched succesfully by my try/catch
with ddtrace1.3.2
installed or without ddtrace, but with ddtrace1.4.*
the exception do not reach mycatch
and php fails with asegmentation fault
.The frequency of the segmentation fault seem to vary due to the location of the trhowed exception:
PHP version
8.2.24
Tracer or profiler version
1.4.*
Installed extensions
[PHP Modules]
amqp
apcu
bcmath
calendar
Core
csv
ctype
curl
date
ddappsec
ddtrace
dom
fileinfo
filter
ftp
gd
gmp
hash
iconv
igbinary
imagick
intl
json
libxml
mbstring
memcached
mongodb
mysqli
mysqlnd
openssl
pcntl
pcov
pcre
PDO
pdo_mysql
pdo_pgsql
pdo_sqlite
Phar
posix
random
readline
redis
Reflection
session
SimpleXML
soap
sockets
sodium
SPL
sqlite3
standard
tokenizer
uuid
xdebug
xml
xmlreader
xmlwriter
xsl
yaml
Zend OPcache
zip
zlib
[Zend Modules]
Xdebug
Zend OPcache
ddappsec
ddtrace
Output of
phpinfo()
Upgrading from
1.3.2
The text was updated successfully, but these errors were encountered: