Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: datadog-setup.php script is not usable when installed with composer.json #2730

Open
VincentLanglet opened this issue Jun 24, 2024 · 0 comments
Labels
🐛 bug Something isn't working

Comments

@VincentLanglet
Copy link

Bug report

When downloading the datadog-setup.php file from the release it works fine https://github.com/DataDog/dd-trace-php/releases/tag/1.1.0. But when using a dependency tool like composer the script doesn't work since it try to work with url like

https://github.com/DataDog/dd-trace-php/releases/download/@release_version@/dd-library-php-@release_version@-x86_64-linux-gnu.tar.gz.

I assume it's because of the PR #1463 (cc @labbati @morrisonlevi)

Since the version number is present (in VERSION file or similar) or can even be found with the composer.lock (With \Composer\InstalledVersion for instance), it would be great to auto-fill the @release_version@ placeholder.

This way

composer install datadog/dd-trace
php vendor/datadog/dd-trace/datadog-setup.php

would work without anything else.

PHP version

8.3.7

Tracer or profiler version

1.1.0

Installed extensions

Irrelevant

Output of phpinfo()

Irrelevant

Upgrading from

No response

@VincentLanglet VincentLanglet added the 🐛 bug Something isn't working label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant