-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dd-trace v5.22.0 requiring graphql? #4648
Comments
+1 this is an issue with all of our typescript projects... I have added graphql as a devDependency in the mean time to get them to build. Should graphql be a dependency instead? |
The project does not depend on graphql however static analysis tools will discover the const visitor_1 = require("graphql/language/visitor");
const printer_1 = require("graphql/language/printer");
const utilities_1 = require("graphql/utilities"); Does anyone have recommendations on how to prevent such tools from parsing the requires? E.g. is there something we can do with string concatenation? const visitor_1 = require("graphq" + "l/language/visitor"); This sometimes affects users with esbuild projects, too. |
Funny enough nothing really changed with that file between those two versions of the tracer. Did anything else with your setup change, like the version of TypeScript? The esbuild issue I mentioned has been happening for ages. |
Hello,
GH dependabot has made a PR in my repo to update
dd-trace
fromv5.21.0
tov5.22.0
. Checking out the feature branch locally, I'm met with these errors on app startup stating thatdd-trace
could not resolve thesegraphql
packages. Is this correct?? Isdd-trace
now requiringgraphql
?The text was updated successfully, but these errors were encountered: