-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should clone record before calling .Add on it for the Go "slog" integration #2918
Labels
bug
unintended behavior that has to be fixed
Comments
github-actions
bot
added
the
needs-triage
New issues that have not yet been triaged
label
Oct 8, 2024
felixge
added a commit
that referenced
this issue
Oct 15, 2024
Fix a bug that could manifest itself when a slog Record is modified concurrently (A) with our handler.Handle implementation (B). If A completes before B, then it might overwrite an attribute added by A. Add test case demonstrating the issue. Fixes #2918
6 tasks
felixge
added
bug
unintended behavior that has to be fixed
and removed
needs-triage
New issues that have not yet been triaged
labels
Oct 15, 2024
Thanks for spotting and reporting this 🙇. #2929 should fix it. |
felixge
added a commit
that referenced
this issue
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that the Go integration for
slog
does not callrec.Clone()
before adding to the record. The documentation forslog
states:The text was updated successfully, but these errors were encountered: