From bb94c3e6935785b89671fd66b74ee5178a3f2d5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dario=20Casta=C3=B1=C3=A9?= Date: Mon, 2 Sep 2024 16:54:36 +0200 Subject: [PATCH] fix(contrib/net/http): avoid race condition on request value --- contrib/net/http/http_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/net/http/http_test.go b/contrib/net/http/http_test.go index cdae814eae..a4c78cf705 100644 --- a/contrib/net/http/http_test.go +++ b/contrib/net/http/http_test.go @@ -346,7 +346,6 @@ func TestServeMuxGo122Patterns(t *testing.T) { func TestWrapHandlerWithResourceNameNoRace(_ *testing.T) { mt := mocktracer.Start() defer mt.Stop() - r := httptest.NewRequest("GET", "/", nil) resourceNamer := func(_ *http.Request) string { return "custom-resource-name" } @@ -358,6 +357,7 @@ func TestWrapHandlerWithResourceNameNoRace(_ *testing.T) { for i := 0; i < 10; i++ { wg.Add(1) go func() { + r := httptest.NewRequest("GET", "/", nil) w := httptest.NewRecorder() defer wg.Done() mux.ServeHTTP(w, r) @@ -369,7 +369,6 @@ func TestWrapHandlerWithResourceNameNoRace(_ *testing.T) { func TestServeMuxNoRace(_ *testing.T) { mt := mocktracer.Start() defer mt.Stop() - r := httptest.NewRequest("GET", "/", nil) mux := NewServeMux() mux.Handle("/", http.NotFoundHandler()) @@ -377,6 +376,7 @@ func TestServeMuxNoRace(_ *testing.T) { for i := 0; i < 10; i++ { wg.Add(1) go func() { + r := httptest.NewRequest("GET", "/", nil) w := httptest.NewRecorder() defer wg.Done() mux.ServeHTTP(w, r)