Fix iOS SR Text with padding #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiszawadzki
force-pushed
the
louiszawadzki/rum-1820/fix-ios-sr-text-padding
branch
from
b4cf262
to
58d97e7
Compare
louiszawadzki
force-pushed
the
louiszawadzki/rum-1820/fix-ios-sr-text-padding
branch
from
58d97e7
to
c5565e1
Compare
louiszawadzki
force-pushed
the
louiszawadzki/rum-1820/fix-ios-sr-text-padding
branch
from
c5565e1
to
4e0d0c8
Compare
maciejburda
approved these changes
Dec 13, 2023
| @@ -95,11 +95,13 @@ internal struct RCTTextViewWireframesBuilder: SessionReplayNodeWireframesBuilder | |||
|
|
|||
| let DEFAULT_FONT_COLOR = UIColor.black.cgColor | |||
|
|
|||
| // Clipping should be 0 to avoid the text from overflowing when the | |||
| // numberOfLines prop is used. | |||
| private var clip: SRContentClip { | |||
There was a problem hiding this comment.
I think we can drop the clip in that case
There was a problem hiding this comment.
We could... but keeping it (when it will be applied in the player) will enable us to handle ellipsis much better
louiszawadzki
deleted the
louiszawadzki/rum-1820/fix-ios-sr-text-padding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix SR on iOS for texts with padding.
When padding was applied on text, we ended up with a wrong wireframe.
This is due to copy/paste from UITextView recorder that probably works differently.
This is fixed by:
textFrameto apply the paddingSimulator snapshot:
Replay (after):
Replay (before):
Note: I've also made the text vertically aligned on top instead of center.
This does not change anything except in 2 cases:
In combination with https://github.com/DataDog/web-ui/pull/114413 this would enable us to support ellipsis on RN.
From the apps I've tested, ellipsis is more common than unusual line heights.
Lines heights can also be properly fixed if we apply it on the player side, rather than "cheating" with an incorrect positioning:
Review checklist (to be filled by reviewers)