Implement native SR without any custom mapper #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiszawadzki
force-pushed
the
louiszawadzki/rum-1815/implement-native-sr-with-no-extra-mapper
branch
from
3565675 to
5053048
Compare
louiszawadzki
force-pushed
the
louiszawadzki/rum-1815/implement-native-sr-with-no-extra-mapper
branch
from
5053048 to
74b1e8c
Compare
0xnm
reviewed
Oct 27, 2023
...d/src/test/kotlin/com/datadog/reactnative/sessionreplay/DdSessionReplayImplementationTest.kt
Outdated
Show resolved
Hide resolved
...d/src/test/kotlin/com/datadog/reactnative/sessionreplay/DdSessionReplayImplementationTest.kt
Outdated
Show resolved
Hide resolved
...d/src/test/kotlin/com/datadog/reactnative/sessionreplay/DdSessionReplayImplementationTest.kt
Show resolved
Hide resolved
louiszawadzki
force-pushed
the
louiszawadzki/rum-1815/implement-native-sr-with-no-extra-mapper
branch
from
74b1e8c to
3b509bb
Compare
0xnm
approved these changes
Oct 27, 2023
cswatt
approved these changes
Oct 27, 2023
louiszawadzki
deleted the
louiszawadzki/rum-1815/implement-native-sr-with-no-extra-mapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable native SR without adding any custom mapper.
This closes the 1815 task, and unblocks iOS and Android mappers to be written in parallel.
On iOS, we output a native log if we try to enable SR before the SDK.
On Android we don't, I've started an internal discussion about it, that can be deferred to later.
Review checklist (to be filled by reviewers)