From db624a56579fa11b81cf2da0c340db7d14e99888 Mon Sep 17 00:00:00 2001 From: BenHinthorne Date: Fri, 14 Jun 2024 14:24:01 -0400 Subject: [PATCH] fix option --- cluster-autoscaler/expander/grpcplugin/grpc_client.go | 1 - cluster-autoscaler/main.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cluster-autoscaler/expander/grpcplugin/grpc_client.go b/cluster-autoscaler/expander/grpcplugin/grpc_client.go index b2d7fe8941a6..819b615734a4 100644 --- a/cluster-autoscaler/expander/grpcplugin/grpc_client.go +++ b/cluster-autoscaler/expander/grpcplugin/grpc_client.go @@ -105,7 +105,6 @@ func (g *grpcclientstrategy) BestOptions(expansionOptions []expander.Option, nod klog.V(4).Info("Unable to sanitize GPRC returned bestOptions, no options filtered") return expansionOptions } - // We would want these options to only have the similar nodegroups that the expander has not filtered out return options } diff --git a/cluster-autoscaler/main.go b/cluster-autoscaler/main.go index 3262753a380f..3b896ce91725 100644 --- a/cluster-autoscaler/main.go +++ b/cluster-autoscaler/main.go @@ -178,7 +178,7 @@ var ( grpcExpanderCert = flag.String("grpc-expander-cert", "", "Path to cert used by gRPC server over TLS") grpcExpanderURL = flag.String("grpc-expander-url", "", "URL to reach gRPC expander server.") - includeSimilarNodegroupsInExpanderOptions = flag.Bool("include-similar-nodegroups-in-expander-options", false, "if true, similar nodegroups will be included in the BestOptions request to the expander") + includeSimilarNodegroupsInExpanderOptions = flag.Bool("include-similar-nodegroups-in-expander-options", false, "If true, similar nodegroups will be included in the BestOptions sent to and returned by expander") ignoreDaemonSetsUtilization = flag.Bool("ignore-daemonsets-utilization", false, "Should CA ignore DaemonSet pods when calculating resource utilization for scaling down")