Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import RPM keys directly from URL #475

Merged
merged 1 commit into from
May 16, 2023
Merged

Import RPM keys directly from URL #475

merged 1 commit into from
May 16, 2023

Conversation

thetic
Copy link
Contributor

@thetic thetic commented Mar 2, 2023

Forced downloads to /tmp/ are not idempotent.

Closes #474.

@thetic
Import RPM keys directly from URL
0599495 
Forced downloads to `/tmp/` are not idempotent.
@thetic thetic requested a review from a team as a code owner March 2, 2023 17:09
@thetic thetic force-pushed the main branch 3 times, most recently from 607dd30 to 0599495 Compare March 2, 2023 17:27
bkabrda
bkabrda approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for opening the PR and sorry for the long wait to get it reviewed!

@bkabrda bkabrda merged commit 8c3e2a9 into DataDog:main May 16, 2023
@bkabrda bkabrda mentioned this pull request May 16, 2023
Closed
@thetic
Copy link
Contributor Author

thetic commented May 17, 2023

Thank you! Any idea when this will be released?

KevinFairise2 added a commit that referenced this pull request Jul 17, 2023
@KevinFairise2
Revert "Import RPM keys directly from URL (#475)"
fa1b088 
This reverts commit 8c3e2a9.
This was referenced Jul 17, 2023
Merged
Open
KevinFairise2 added a commit that referenced this pull request Jul 17, 2023
@KevinFairise2
Revert "Import RPM keys directly from URL" (#502)
0fe67ae 
* Revert "Import RPM keys directly from URL (#475)"

This reverts commit 8c3e2a9.

* Fix lint and key 2028 import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkabrda bkabrda bkabrda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Download current RPM key" task runs invariably.
2 participants
@thetic @bkabrda