Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-46: Disable DAA work until we can get back to it in the future. #2731

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

rushtong
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-46

Summary

DAA work has been pushed off for at least the next six months. In the meantime, we should disable it so that dev work is closer to what is released to production.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review November 18, 2024 19:10
@rushtong rushtong requested a review from a team as a code owner November 18, 2024 19:10
@rushtong rushtong requested review from snf2ye and cinyecai and removed request for a team November 18, 2024 19:10
Copy link
Contributor

@rjohanek rjohanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any testing repercussions? Are there tests we need to disable or add or anything like that?

@rushtong
Copy link
Contributor Author

Does this have any testing repercussions? Are there tests we need to disable or add or anything like that?

Our tests are 100% component tests and all tests passed, so there should be no issues on that front.

src/utils/DAAUtils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this will help me test potential dataset issues in the Data Library 👍

fix typo

Co-authored-by: Phil Shapiro <[email protected]>
@rushtong rushtong merged commit 40201be into develop Nov 18, 2024
9 checks passed
@rushtong rushtong deleted the gr-DT-46-disable-DAAs branch November 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants