From 87c3e6000a462c8e16f2c34e49929dc77018ef94 Mon Sep 17 00:00:00 2001 From: Darshit Chanpura Date: Wed, 21 Aug 2024 16:12:59 -0400 Subject: [PATCH] Moves @cliu123 to emeritus status (#4667) Signed-off-by: Darshit Chanpura (cherry picked from commit 8d48838e3bc245e065ae5994a26d7d51c012bed0) --- .github/CODEOWNERS | 2 +- MAINTAINERS.md | 49 +++++++++++++++++++++++++++++++--------------- 2 files changed, 34 insertions(+), 17 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ffa2e33444..859138f4c4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1 @@ -* @cwperks @DarshitChanpura @nibix @peternied @RyanL1997 @stephen-crawford @reta @willyborankin +* @cwperks @DarshitChanpura @peternied @RyanL1997 @stephen-crawford @reta @willyborankin diff --git a/MAINTAINERS.md b/MAINTAINERS.md index db68683708..69dd039815 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -1,40 +1,57 @@ -- [OpenSearch Security Maintainers](#opensearch-security-maintainers) - - [Maintainers](#maintainers) - - [Practices](#practices) - - [Updating Practices](#updating-practices) -- [Practices](#practices-1) +- [Overview](#overview) +- [Current Maintainers](#current-maintainers) +- [Practices](#practices) + - [Updating Practices](#updating-practices) - [Reverting Commits](#reverting-commits) - - [Performing Revert](#performing-revert) + - [Performing Revert](#performing-revert) + - [Squashing a Pull Request](#squashing-a-pull-request) -# OpenSearch Security Maintainers +## Overview + +This document contains a list of maintainers in this repo. See [opensearch-project/.github/RESPONSIBILITIES.md](https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#maintainer-responsibilities) that explains what the role of maintainer means, what maintainers do in this and other repos, and how they should be doing it. If you're interested in contributing, and becoming a maintainer, see [CONTRIBUTING](CONTRIBUTING.md). + +## Current Maintainers -## Maintainers | Maintainer | GitHub ID | Affiliation | -| ---------------- | ----------------------------------------------------- | ----------- | -| Chang Liu | [cliu123](https://github.com/cliu123) | Amazon | +|------------------|-------------------------------------------------------|-------------| | Darshit Chanpura | [DarshitChanpura](https://github.com/DarshitChanpura) | Amazon | -| Dave Lago | [davidlago](https://github.com/davidlago) | Amazon | | Peter Nied | [peternied](https://github.com/peternied) | Amazon | | Craig Perkins | [cwperks](https://github.com/cwperks) | Amazon | | Ryan Liang | [RyanL1997](https://github.com/RyanL1997) | Amazon | -| Stephen Crawford | [scrawfor99](https://github.com/scrawfor99) | Amazon | +| Stephen Crawford | [scrawfor99](https://github.com/stephen-crawford) | Amazon | | Andriy Redko | [reta](https://github.com/reta) | Aiven | | Andrey Pleskach | [willyborankin](https://github.com/willyborankin) | Aiven | -| Nils Bandener | [nibix](https://github.com/nibix) | Eliatra | + +## Emeritus + +| Maintainer | GitHub ID | Affiliation | +|------------|-------------------------------------------|-------------| +| Dave Lago | [davidlago](https://github.com/davidlago) | Contributor | +| Chang Liu | [cliu123](https://github.com/cliu123) | Amazon | ## Practices ### Updating Practices -To ensure common practices as maintainers, all practices are expected to be documented here or enforced through github actions. There should be no expectations beyond what is documented in the repo [CONTRIBUTING.md](./CONTRIBUTING.md) and OpenSearch-Project [CONTRIBUTING.md](https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md). To modify an existing processes or create a new one, make a pull request on this MAINTAINERS.md for review and merge it after all maintainers approve of it. -# Practices +To ensure common practices as maintainers, all practices are expected to be documented here or enforced through github actions. There should be no expectations beyond what is documented in the repo [CONTRIBUTING.md](./CONTRIBUTING.md) and OpenSearch-Project [CONTRIBUTING.md](https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md). To modify an existing processes or create a new one, make a pull request on this MAINTAINERS.md for review and merge it after all maintainers approve of it. + +### Reverting Commits -## Reverting Commits There will be changes that destabilize or block contributions. The impact of these changes will be localized on the repository or even the entire OpenSearch project. We should bias towards keeping contributions unblocked by immediately reverting impacting changes, these reverts will be done by a maintainer. After the change has been reverted, an issue will be openned to re-merge the change and callout the elements of the contribution that need extra examination such as additional tests or even pull request workflows. Exceptional, instead of immediately reverting, if a contributor knows how and will resolve the issue in an hour or less we should fix-forward to reduce overhead. ### Performing Revert + Go to the pull request of the change that was an issue, there is a `Revert` button at the bottom. If there are no conflicts to resolve, this can be done immediately bypassing standard approval. Reverts can also be done via the command line using `git revert ` and creating a new pull request. If done in this way they should have references to the pull request that was reverted. + +### Squashing a Pull Request + +When a PR is going to be merged, our repositories are set to automatically squash the commits into a single commit. This process needs human intervention to produce high quality commit messages, with the following steps to be followed as much as possible: + +- The commit subject is clean and conveys what is being merged +- The commit body should include the details (if any) about the commit, typically inline with the PR description +- The commit body should include the 'Signed-Off-By:*' for all committers involved in the change. +- There need to be a matching 'Signed-Off-By:' line for the `This commit will be authored by *` email address otherwise backport DCO checks will fail.