From 738df2150fcd87d40128cff7ba786e4e074a3299 Mon Sep 17 00:00:00 2001
From: "opensearch-trigger-bot[bot]"
 <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Date: Mon, 29 Apr 2024 15:43:25 -0400
Subject: [PATCH] [Backport 2.x] REST API tests refactoring (Part 3) (#4300)

Signed-off-by: Andrey Pleskach <ples@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
---
 .../rest/api/SecurityHealthActionTest.java    | 48 -------------------
 .../LegacySecurityHealthActionTests.java      | 23 ---------
 2 files changed, 71 deletions(-)
 delete mode 100644 src/test/java/org/opensearch/security/dlic/rest/api/SecurityHealthActionTest.java
 delete mode 100644 src/test/java/org/opensearch/security/dlic/rest/api/legacy/LegacySecurityHealthActionTests.java

diff --git a/src/test/java/org/opensearch/security/dlic/rest/api/SecurityHealthActionTest.java b/src/test/java/org/opensearch/security/dlic/rest/api/SecurityHealthActionTest.java
deleted file mode 100644
index e239050612..0000000000
--- a/src/test/java/org/opensearch/security/dlic/rest/api/SecurityHealthActionTest.java
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * SPDX-License-Identifier: Apache-2.0
- *
- * The OpenSearch Contributors require contributions made to
- * this file be licensed under the Apache-2.0 license or a
- * compatible open source license.
- *
- * Modifications Copyright OpenSearch Contributors. See
- * GitHub history for details.
- */
-
-package org.opensearch.security.dlic.rest.api;
-
-import org.apache.http.HttpStatus;
-import org.junit.Assert;
-import org.junit.Test;
-
-import org.opensearch.common.settings.Settings;
-import org.opensearch.security.support.ConfigConstants;
-import org.opensearch.security.test.helper.rest.RestHelper;
-
-import static org.opensearch.security.OpenSearchSecurityPlugin.PLUGINS_PREFIX;
-
-public class SecurityHealthActionTest extends AbstractRestApiUnitTest {
-    private final String ENDPOINT;
-
-    protected String getEndpointPrefix() {
-        return PLUGINS_PREFIX;
-    }
-
-    public SecurityHealthActionTest() {
-        ENDPOINT = getEndpointPrefix();
-    }
-
-    @Test
-    public void testSecurityHealthAPI() throws Exception {
-        Settings settings = Settings.builder()
-            .put(ConfigConstants.SECURITY_UNSUPPORTED_RESTAPI_ALLOW_SECURITYCONFIG_MODIFICATION, true)
-            .build();
-        setup(settings);
-
-        rh.keystore = "restapi/kirk-keystore.jks";
-        rh.sendAdminCertificate = true;
-
-        RestHelper.HttpResponse response = rh.executeGetRequest(ENDPOINT + "/health");
-        Assert.assertEquals(HttpStatus.SC_OK, response.getStatusCode());
-    }
-}
diff --git a/src/test/java/org/opensearch/security/dlic/rest/api/legacy/LegacySecurityHealthActionTests.java b/src/test/java/org/opensearch/security/dlic/rest/api/legacy/LegacySecurityHealthActionTests.java
deleted file mode 100644
index 99fa4a99ae..0000000000
--- a/src/test/java/org/opensearch/security/dlic/rest/api/legacy/LegacySecurityHealthActionTests.java
+++ /dev/null
@@ -1,23 +0,0 @@
-/*
- * SPDX-License-Identifier: Apache-2.0
- *
- * The OpenSearch Contributors require contributions made to
- * this file be licensed under the Apache-2.0 license or a
- * compatible open source license.
- *
- * Modifications Copyright OpenSearch Contributors. See
- * GitHub history for details.
- */
-
-package org.opensearch.security.dlic.rest.api.legacy;
-
-import org.opensearch.security.dlic.rest.api.SecurityHealthActionTest;
-
-import static org.opensearch.security.OpenSearchSecurityPlugin.LEGACY_OPENDISTRO_PREFIX;
-
-public class LegacySecurityHealthActionTests extends SecurityHealthActionTest {
-    @Override
-    protected String getEndpointPrefix() {
-        return LEGACY_OPENDISTRO_PREFIX;
-    }
-}