Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Limit the number of players that can join a team #1187

Merged
merged 3 commits into from
Aug 18, 2023
Merged

fix: Limit the number of players that can join a team #1187

merged 3 commits into from
Aug 18, 2023

Conversation

aronwk-aaron
Copy link
Member

after being invited

Tested that the server compiles and does not crash

EmosewaMC
EmosewaMC previously approved these changes Aug 18, 2023
View reviewed changes
Wincent01
Wincent01 reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@Wincent01 Wincent01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to notify the affected parties that this has happened? If not through something else, a chat message would probably be good.

@aronwk-aaron
Copy link
Member Author

Is there a way to notify the affected parties that this has happened? If not through something else, a chat message would probably be good.

Done

@aronwk-aaron aronwk-aaron requested a review from EmosewaMC August 18, 2023 21:23
@aronwk-aaron aronwk-aaron changed the title Limit the number of players that can join a team fix: Limit the number of players that can join a team Aug 18, 2023
@aronwk-aaron aronwk-aaron merged commit 2e386d2 into main Aug 18, 2023
@aronwk-aaron aronwk-aaron deleted the limit-the-number-of-players-that-can-join-a-team-after-invite branch August 18, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jettford Jettford Jettford approved these changes

@EmosewaMC EmosewaMC EmosewaMC approved these changes

@DarwinAnim8or DarwinAnim8or Awaiting requested review from DarwinAnim8or

@Wincent01 Wincent01 Awaiting requested review from Wincent01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aronwk-aaron @Wincent01 @EmosewaMC @Jettford