perf: Add path height correction on world load #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
changed the title
|
I am seeing more successful queries when using a X and Z halfExtents of zero. about 5% more successful queries from before. |
|
This is resulting in 100% successful queries now. |
|
ran around quite a bit in gnarled forest, crux prime, return to venture explorer and saw no issues with enemies teleporting. |
|
The poly height always matching the one from rhe nearest reg is further reinforced by the lookup now being directly vertical with so variance in the x or z axis. This ensures you find the correct height or find nothing |
- Only go up and down, do not deviate from the point you are on - As a backup, use the nearestPoint on the nearestPoly, should detour be able to find one. - Add a debug assert to fail the program should toReturn differ from nearestPoint[1]. Update dNavMesh.cpp Update dNavMesh.cpp
EmosewaMC
force-pushed
the
movementAiPathing
branch
from
eb7fc24 to
8da23df
Compare
|
Re-tested without capturing the res return from getPolyHeight and actually returning the correct value and no changes except from the expected path fixes. |
aronwk-aaron
approved these changes
Aug 9, 2023
DarwinAnim8or
previously approved these changes
Aug 10, 2023
Wincent01
previously approved these changes
Aug 11, 2023
aronwk-aaron
previously approved these changes
Aug 11, 2023
aronwk-aaron
dismissed stale reviews from Wincent01, DarwinAnim8or, and themself
via
3277201
aronwk-aaron
approved these changes
Aug 11, 2023
DarwinAnim8or
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because many waypoints for movement place the Y at some height far below the map, we need to correct this height to match that of the navmesh. Doing this at runtime is very expensive as some maps are very tall and so the halfExtents would need to be very large. Doing this at world load is a far more ideal place to take care of this as this only really needs to be done once so that at runtime, more approximate heights can be calculated with the same halfExtents as currently.
Tested that there are no changes aside from the height being changed at world startup. This may resolve issues with some AI being unable to find a close waypoint on the navmesh due to their waypoint height being far too low for the halfExtents to allow finding of the nearest poly.