Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Missing g++10 requirements #1625

Open
2 tasks done
leolion3 opened this issue Jul 11, 2024 · 4 comments
Open
2 tasks done

DOC: Missing g++10 requirements #1625

leolion3 opened this issue Jul 11, 2024 · 4 comments
Labels
docs There's something wrong or missing with the documentation P-Fixer This issue is confirmed, but is not prioritized to be fixed.

Comments

@leolion3
Copy link

leolion3 commented Jul 11, 2024

Make sure you've done the following:

  • I have checked that this issue has not already been reported.

  • I have validated that the documentation is wrong or missing on the latest version of the main branch of DarkflameServer

Location of the documentation

https://github.com/DarkflameUniverse/DarkflameServer/blob/main/README.md

Documentation problem

The documentation is missing the fact that recent server versions require a gcc version of 10 to compile, since <span> is not part of the standard library in gcc 9.

Suggested fix for documentation

Change as required:

# Install lib essential with default gcc 9
sudo apt install build-essential

# Add key to toolchain
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt update

# Replace gcc/g++ 9 with 10
sudo apt install gcc-10 g++-10
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 10
sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-10 10

# Validate
gcc --version
g++ --version
@leolion3 leolion3 added docs There's something wrong or missing with the documentation triage An issue that needs triage labels Jul 11, 2024
@EmosewaMC EmosewaMC removed the triage An issue that needs triage label Jul 11, 2024
@EmosewaMC
Copy link
Collaborator

the gcc default is dependent more on the distribution you are on and less what is on build essentials. A more accurate fix would be to have the user just install gcc-10 however they need to on their platform, which for some is just gcc and for others is the more complicated steps above due to the published package being too old for that distribution.

@EmosewaMC EmosewaMC added the P-Fixer This issue is confirmed, but is not prioritized to be fixed. label Jul 11, 2024
@leolion3
Copy link
Author

leolion3 commented Jul 12, 2024

the gcc default is dependent more on the distribution you are on and less what is on build essentials. A more accurate fix would be to have the user just install gcc-10 however they need to on their platform, which for some is just gcc and for others is the more complicated steps above due to the published package being too old for that distribution.

either way would be good to reference it. I updated to the latest server version and couldnt rebuild and spent an hour looking for the problem until I found a reference that the said <span> lib import is not available and another hour trying to install g++10 on my oracle VM running Ubuntu 22.04. So I thought Id just leave the entire code as a reference.

Edit: following the basic install instructions makes you end up with a gcc version of 9.x which isnt enough.

@jadebenn
Copy link
Collaborator

As an update to this, as per the discussion on #1652, it looks like the minimum required version of gcc is actually 11 now.

@EmosewaMC
Copy link
Collaborator

we're moving towards ditching requiring end users to build the server as well, so this will only be an issue for developers in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs There's something wrong or missing with the documentation P-Fixer This issue is confirmed, but is not prioritized to be fixed.
Projects
None yet
Development

No branches or pull requests

3 participants