From 1912dff36b061a0493ce8f7ff4a73ab159203f47 Mon Sep 17 00:00:00 2001 From: Danny Ben Shitrit Date: Mon, 17 Jul 2023 05:59:06 +0000 Subject: [PATCH] require spec_helper once only --- .rspec | 1 + .rubocop.yml | 8 ++++++-- spec/victor/attributes_spec.rb | 2 -- spec/victor/css_spec.rb | 2 -- spec/victor/dsl_spec.rb | 2 -- spec/victor/script_spec.rb | 2 -- spec/victor/svg_base_spec.rb | 2 -- spec/victor/svg_spec.rb | 2 -- 8 files changed, 7 insertions(+), 14 deletions(-) diff --git a/.rspec b/.rspec index e41f336..fd2aa2d 100644 --- a/.rspec +++ b/.rspec @@ -1,3 +1,4 @@ +--require spec_helper --color --format documentation --fail-fast \ No newline at end of file diff --git a/.rubocop.yml b/.rubocop.yml index 80e9396..a6a5387 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -35,10 +35,14 @@ Metrics/PerceivedComplexity: # This test is allowed to use `eval` Security/Eval: Exclude: - - 'spec/victor/script_spec.rb' + - spec/victor/script_spec.rb # Allow `include Victor` in some places Style/MixinUsage: Exclude: - 'examples/*' - - 'lib/victor/script.rb' + - lib/victor/script.rb + +RSpec/ExampleLength: + Exclude: + - spec/victor/svg_spec.rb diff --git a/spec/victor/attributes_spec.rb b/spec/victor/attributes_spec.rb index ad7d328..8968fd6 100644 --- a/spec/victor/attributes_spec.rb +++ b/spec/victor/attributes_spec.rb @@ -1,5 +1,3 @@ -require 'spec_helper' - describe Attributes do attrs = nil subject { described_class.new attrs } diff --git a/spec/victor/css_spec.rb b/spec/victor/css_spec.rb index bb0405e..14e0d78 100644 --- a/spec/victor/css_spec.rb +++ b/spec/victor/css_spec.rb @@ -1,5 +1,3 @@ -require 'spec_helper' - describe CSS do subject { described_class.new css } diff --git a/spec/victor/dsl_spec.rb b/spec/victor/dsl_spec.rb index 8c7ec71..ab7e71d 100644 --- a/spec/victor/dsl_spec.rb +++ b/spec/victor/dsl_spec.rb @@ -1,5 +1,3 @@ -require 'spec_helper' - describe DSL do subject { Class.new { include DSL }.new } diff --git a/spec/victor/script_spec.rb b/spec/victor/script_spec.rb index 2cb6970..362605b 100644 --- a/spec/victor/script_spec.rb +++ b/spec/victor/script_spec.rb @@ -1,5 +1,3 @@ -require 'spec_helper' - describe 'victor/script' do subject { File.read 'spec/fixtures/dsl_script.rb' } diff --git a/spec/victor/svg_base_spec.rb b/spec/victor/svg_base_spec.rb index 71bf1c1..933aec4 100644 --- a/spec/victor/svg_base_spec.rb +++ b/spec/victor/svg_base_spec.rb @@ -1,5 +1,3 @@ -require 'spec_helper' - describe SVGBase do it 'does not define #method_missing' do expect { subject.polygon }.to raise_error NoMethodError diff --git a/spec/victor/svg_spec.rb b/spec/victor/svg_spec.rb index 6e2aa02..0462a3b 100644 --- a/spec/victor/svg_spec.rb +++ b/spec/victor/svg_spec.rb @@ -1,5 +1,3 @@ -require 'spec_helper' - describe SVG do describe '#new' do it 'sets default attributes' do