type: feat #22
type: feat #22
Conversation
Added new parameter "useCredentials" on constructor to choce if want use key/secret or credentials file on loca folder. Issue DanielHindi#21 Added new parameter "folderPath" on zipToS3File to choce if want bucket folder structure inside zip file or only files. Issue DanielHindi#20 Resolves: DanielHindi#21, DanielHindi#20
|
Thanks for helping fix these issues. Should probably bump up the package version, right? If you're interested I'm looking for someone to help manage this module. Let me know |
|
Hi @DanielHindi, thanks for the invite, but i don't have much time to invest in that now. Can I help with some pull requests sometimes, but I will not assume this compromise like a collaborator. And yes, this code will need a version to release, but will not lose the compatibility of the older version, because the two added parameter is optional. |
|
Hey lipeRomani, |
|
Hi there, is there any update on this feature ? I'm interested in both update: useCredentials and folderPath |
There was a problem hiding this comment.
@lipeRomani please see my review comment before this can be merged.
| @@ -10,12 +10,6 @@ | |||
| "s3": "latest" | |||
| }, | |||
| "repository": "https://github.com/DanielHindi/aws-s3-zipper.git", | |||
| "keywords": [ | |||
There was a problem hiding this comment.
Please undo the deletion of the keywords parameter and its values.
|
This hasn't been merged since 2018??? |
Added new parameter "useCredentials" on constructor to choce if want use key/secret or credentials file on loca folder. Issue #21
Added new parameter "folderPath" on zipToS3File to choce if want bucket folder structure inside zip file or only files. Issue #20
Resolves: #21, #20