Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3 was a breaking release #26

Open
Vampire opened this issue Aug 16, 2024 · 1 comment
Open

1.3 was a breaking release #26

Vampire opened this issue Aug 16, 2024 · 1 comment

Comments

@Vampire
Copy link

Vampire commented Aug 16, 2024

Upgrading the node version is a breaking change.
So actually 1.3 should have been 2.0.
I also did this wrong in the past and learned this from my action's users.
If the action is used on a custom self-hosted runner, there is no guarantee that the new Node version is available and so updating the node version is a breaking change.

Feel free to decide how you proceed or whether you ignore the breaking change.
Back then I reverted the change, cut a new release and did the change in a directly following major version release.

@DamianReeves
Copy link
Owner

Apologies for staleness... I need to check my notifications in GitHub a bit more. Will be refreshing between now and end of year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants