Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flattening logic surveycto #78

Merged
merged 3 commits into from
May 31, 2024

Conversation

Abhishek-N
Copy link

No description provided.

Copy link

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link

@fatchat fatchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happends when KEY is null?

You have tested, you have looked at the data, you have run multiple syncs of the same stream?

@Abhishek-N
Copy link
Author

streams that are selected
Screenshot 2024-04-23 at 11 50 57 AM

data after synced
Screenshot 2024-04-23 at 12 16 18 PM

Data looks good for transformation through dbt for the json column data. Here we use SubmissionDate as cursor_field

@fatchat fatchat had a problem deploying to community-ci-auto May 11, 2024 03:47 — with GitHub Actions Failure
@fatchat fatchat had a problem deploying to community-ci-auto May 11, 2024 03:47 — with GitHub Actions Failure
@fatchat fatchat changed the base branch from master to feature/source-surveycto May 31, 2024 06:12
@fatchat fatchat merged commit 64ca075 into feature/source-surveycto May 31, 2024
9 of 17 checks passed
@fatchat fatchat deleted the remove-flattening-logic-surveycto branch May 31, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants