Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python3 the default language #37

Open
illwieckz opened this issue May 10, 2020 · 5 comments
Open

Make python3 the default language #37

illwieckz opened this issue May 10, 2020 · 5 comments

Comments

@illwieckz
Copy link
Member

The shebang still relies on python (and does not use env), maybe it already works with python3 but I haven't tested.

Since Python2 is now deprecated we must:

  • check that it works with Python3
  • edit shebang to use /usr/bin/env python3 instead of /usr/bin/python

Since Python2 is now deprecated we can:

  • drop any Python2-ism if exist, we don't have to care about them anymore, and no one would have right to blame use for this.
@illwieckz
Copy link
Member Author

illwieckz commented May 10, 2020

For reference, after having upgraded my Ubuntu setup to 20.04 “focal” release, Python2 got uninstalled so I was not able to build the game… Fortunately I was able to reinstall Python2 but it means so many applications were ported that my own installation did not required Python2 for distro-provided packages I use.

@illwieckz
Copy link
Member Author

@Viech is that something you can investigate?

@slipher
Copy link
Member

slipher commented May 10, 2020

As I recall, Viech actually originally targeted Python 3 when writing the scripts. We then requested Python 2 compatibility so that it could use the same interpreter as the NaCl toolchain. Viech expressed dismay at this requirement, but then it turned out that the code already worked in Python 2 without any modifications. (I even managed to find this conversation in my logs, but it is fairly long and noisy so I will not post it.)

@Viech
Copy link
Member

Viech commented May 13, 2020

That does sound like @Viech (who is a Python library developer these days and is still haunted by Python 2 compatibility requirements on a semidaily basis).

@illwieckz
Copy link
Member Author

So, the real issue seems to be the NaCl toolchain… 😕

@necessarily-equal necessarily-equal changed the title Make python3 the default language, make sure it works first Make python3 the default language Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants