Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag-and-Drop Malfunction in submission form #3624

Open
Simone-Ramundi opened this issue Nov 8, 2024 · 1 comment
Open

Drag-and-Drop Malfunction in submission form #3624

Simone-Ramundi opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back component: submission

Comments

@Simone-Ramundi
Copy link
Contributor

Simone-Ramundi commented Nov 8, 2024

Describe the bug

When starting a new submission of an Item that has a field with the chips buttons (e.g 'dc.subject' for Publication) if the metadata has multiple values distributed into rows, the drag&drop functionality will not work between rows.

Screencast.from.08-11-24.17.25.32.webm

In DSpace, when using Angular Material’s drag-and-drop (cdkDropList) with cdkDrag in a multi-row layout, drag-and-drop functionality fails if items span more than one row. Specifically, when attempting to drag an item between rows, the intended swap does not occur, and items in other rows may shift unexpectedly. This issue limits the functionality to single-row layouts.

This issue arises because the current version (17.3.10) of Angular Material’s cdkDropList does not natively support multi-row. Support of multiple row has been added to Angular 18.

So for DSpace 9 the fix can be done when upgrading to Angular 18. While in DSpace 8, which uses an earlier Angular version, we need a custom fix.

To Reproduce

Steps to reproduce the behavior:

  1. Go to sandbox.dspace.org and start a new Item submission in the "Articles" collection.
  2. In the Describe section, under "Subject Keyword," add enough items to create multiple rows.
  3. Attempt to drag an item from one row to another, and observe the bug as items shift incorrectly.

Expected behavior

Drag-and-drop functionality should work seamlessly across multiple rows, allowing users to swap items without causing other rows to shift.

@Simone-Ramundi Simone-Ramundi added bug needs triage New issue needs triage and/or scheduling labels Nov 8, 2024
@Simone-Ramundi Simone-Ramundi self-assigned this Nov 8, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 8, 2024
@Simone-Ramundi
Copy link
Contributor Author

@tdonohue 4Science will work on it

@tdonohue tdonohue added affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases and removed needs triage New issue needs triage and/or scheduling labels Nov 8, 2024
@tdonohue tdonohue removed this from DSpace Backlog Nov 8, 2024
@tdonohue tdonohue added component: submission claimed: 4Science 4Science team is working on this issue & will contribute back labels Nov 8, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back component: submission
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

2 participants