Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar in facets does not disappear if the number of facet values is a multiple of the pagination's page size #3611

Open
AndreaBarbasso opened this issue Nov 6, 2024 · 0 comments · May be fixed by #3616
Assignees
Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug component: Discovery related to discovery search or browse system

Comments

@AndreaBarbasso
Copy link
Contributor

Describe the bug

If the number of values in a facet is a multiple of the size of each page during pagination (i.e. each page is full), the search bar below the facet values does not disappear when all the facet values are shown.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any search page and do a search that retrieves, for a single facet, a number of values multiple of 5.
  2. Continue clicking on the "show more" button until it disappears, while the search bar does not disappear.

e.g. https://sandbox.dspace.org/search?spc.page=1&f.author=Abdominal%20and%20Paediatric%20Surgery,equals

image

Expected behavior

The seach bar should disappear when there are no more facet values pages to load.

@AndreaBarbasso AndreaBarbasso added bug needs triage New issue needs triage and/or scheduling labels Nov 6, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 6, 2024
@AndreaBarbasso AndreaBarbasso self-assigned this Nov 6, 2024
@tdonohue tdonohue added component: Discovery related to discovery search or browse system affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases and removed needs triage New issue needs triage and/or scheduling labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug component: Discovery related to discovery search or browse system
Projects
Status: 🆕 Triage
Development

Successfully merging a pull request may close this issue.

2 participants