Fix navbar wrapping on medium screens #3513
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Removed a
white-space: nowrap
rule, added someflex-shrink
andflex-grow
classes, and removed aflex-wrap
class so that the navbar is not wrapping anymore on two lines.Instructions for Reviewers
As said on #3512, on medium-sized screens the navbar could wrap on another row if there were more than 3 items in it. This PR introduces some template and style changes to avoid this behavior.
List of changes in this PR:
white-space: nowrap;
rule` that was wrapping the navbar onto another row;To reproduce the issue you can simply duplicate a navbar item and resize the screen. With this PR there is no wrapping or overflowing of items.
Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.