Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There could be more than one Entity reference for external sources #90

Open
paulo-graca opened this issue Nov 6, 2019 · 1 comment
Open

Comments

@paulo-graca
Copy link
Contributor

https://github.com/DSpace/Rest7Contract/blob/master/external-authority-sources.md


     },
        "type": "externalSourceEntry",
        "_links": {
          "entity": {
            "href": "https://dspace7.4science.cloud/server/api/core/item/6fd90bf5-b84f-47b3-aaec-a55bde3a2a5a"
          },
          "self": {
            "href": "https://dspace7.4science.cloud/server/api/integration/externalsources/orcid/entryValues/0000-0003-3681-2038"
          }
        }
      }

which regards the entity reference in the example above, there are cases where can exist more than one. By default It should be an array. Example:

"_links": {
          "entity": [{
            "href": "https://dspace7.4science.cloud/server/api/core/item/6fd90bf5-b84f-47b3-aaec-a55bde3a2a5a"
          }],
@tdonohue
Copy link
Member

tdonohue commented Oct 8, 2020

I'm not sure how to move this forward, as I don't see this entity link anywhere in our codebase at https://github.com/DSpace/DSpace. I think the documentation may be incorrect, as I only see a self link in responses from this endpoint (including when I try the demo site, e.g. https://dspace7.4science.cloud/server/#https://dspace7.4science.cloud/server/api/integration/externalsources/pubmed/entryValues/33027802)

Therefore, I think this likely should be closed and the contract updated to remove the entity link.

@benbosman : as I believe you added this code, am I missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants