Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project instead of funding mentionment in ORCID synchronization preferences #255

Closed
floriangantner opened this issue Feb 21, 2024 · 0 comments · Fixed by #256
Closed

Project instead of funding mentionment in ORCID synchronization preferences #255

floriangantner opened this issue Feb 21, 2024 · 0 comments · Fixed by #256
Assignees
@floriangantner
Labels
enhancement
Milestone
7.6.2

Comments

@floriangantner
Copy link
Contributor

Please describe your request
The contract mentions some /api/eperson/profiles/<:eperson-uuid>/orcid/projects endpoint which does not exist.

RestContract/profiles.md

Line 238 in 7906b33

* **/orcid/projects** - to update the preference relative to the projects synchronization; allowed values are 'DISABLED', 'ALL'

The corresponding file mentions some /fundings path instead.

https://github.com/DSpace/DSpace/blob/28ad35f858131901dfe3108dcae57ea7328218e3/dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/patch/operation/ResearcherProfileReplaceOrcidSyncPreferencesOperation.java#L57

In Addition the ResearcherProfile Rest OrcidSynchronization setting

RestContract/profiles.md

Line 28 in 7906b33

"projectsPreference": "ALL",

should return some fundingsPreference instead of the projectsPreference

https://github.com/DSpace/DSpace/blob/28ad35f858131901dfe3108dcae57ea7328218e3/dspace-server-webapp/src/main/java/org/dspace/app/rest/converter/ResearcherProfileConverter.java#L61C18-L61C19

https://github.com/DSpace/DSpace/blob/28ad35f858131901dfe3108dcae57ea7328218e3/dspace-server-webapp/src/main/java/org/dspace/app/rest/model/ResearcherProfileRest.java#L94

We provide some PR fixing this.
@floriangantner floriangantner added enhancement needs triage New issue needs triage and/or scheduling labels Feb 21, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Feb 21, 2024
floriangantner added a commit to uniba-ub/Rest7Contract that referenced this issue Feb 21, 2024
@floriangantner
replace orcid profile projects by fundings
371ea16 
DSpace#255
@floriangantner floriangantner mentioned this issue Feb 21, 2024
Merged
@floriangantner floriangantner changed the title Wrong project mentionment in ORCID synchronization preferences Project instead of funding mentionment in ORCID synchronization preferences Feb 21, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.0 Release Feb 21, 2024
@tdonohue tdonohue removed the needs triage New issue needs triage and/or scheduling label Feb 21, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.0 Release May 3, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone May 3, 2024
@tdonohue tdonohue moved this from 📋 To Do to ✅ Done in DSpace 8.x and 7.6.x Maintenance May 3, 2024
github-actions bot pushed a commit that referenced this issue May 3, 2024
@floriangantner @github-actions
replace orcid profile projects by fundings
e67546e 
#255
(cherry picked from commit 371ea16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floriangantner floriangantner

Labels
enhancement
Projects
DSpace 8.x and 7.6.x Maintenance
Archived in project
DSpace 8.0 Release
Archived in project
Milestone
7.6.2
2 participants
@tdonohue @floriangantner