Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of .data where tidyselect should now be used. #56

Open
dblodgett-usgs opened this issue May 31, 2024 · 0 comments
Open

Use of .data where tidyselect should now be used. #56

dblodgett-usgs opened this issue May 31, 2024 · 0 comments

Comments

@dblodgett-usgs
Copy link
Collaborator

dblodgett-usgs commented May 31, 2024

Currently, the package uses the .data$... pattern a lot for both selection and "data-masking". It should only be used for data masking. At this point, it's only a warning and making the changes would be pretty invasive. Since this work is migrating to hydrofab, it's probably a won't fix, but wanted to document the issue here as it shows up as a lot of warnings in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant