Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue that caused label to overlay prefix/suffix #1122

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

valadas
Copy link
Member

@valadas valadas commented Jul 24, 2024

dnn-input supports having a prefix or suffix as slots. Because the label floats as a placeholder until either the component is focused or has a value, this label could partially cover those elements.

With this PR, the prefix or suffix only show once the label slides up.

Closes #1056

dnn-input supports having a prefix or suffix as slots. Because the label floats as a placeholder until either the component is focused or has a value, this label could partially cover those elements.

With this PR, the prefix or suffix only show once the label slides up.

Closes DNNCommunity#1056
@valadas valadas added the bug Something isn't working label Jul 24, 2024
@valadas valadas added this to the 0.24.0 milestone Jul 24, 2024
@valadas valadas requested a review from david-poindexter July 24, 2024 02:06
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉🎉🎉

@david-poindexter david-poindexter merged commit fa0fc10 into DNNCommunity:develop Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field prefix/suffix should probably be hidden until fields have values
2 participants