Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a monaco editor component #494

Closed
valadas opened this issue Mar 15, 2022 · 6 comments
Closed

Create a monaco editor component #494

valadas opened this issue Mar 15, 2022 · 6 comments
Assignees

Comments

@valadas
Copy link
Member

valadas commented Mar 15, 2022

It would be nice if we had a monaco editor web-component wrapper that is easy to use anywhere.

One of the useful places would be to handle DNNCommunity/Dnn.StructuredContent#10

@david-poindexter
Copy link
Contributor

I have already begun work on this. It will be exciting to see this as a possibility for so many use cases!

@david-poindexter
Copy link
Contributor

An initial implementation has now been submitted to the dnn-elements project via #551

@david-poindexter
Copy link
Contributor

@valadas it looks like we still have the dnn-monaco-editor branch sitting there and no PR has been made yet. As a reminder, you wanted to put that on a separate branch for review instead of the normal PR process.

@valadas
Copy link
Member Author

valadas commented Sep 20, 2022

Yeah, I was kinda too busy to do a good review and wanted to test consumption by a consuming project to make sure it's all ok. If you want we could maybe refresh that this weekend...

@david-poindexter
Copy link
Contributor

david-poindexter commented Nov 14, 2022

@valadas I really want to get this branch merged so I can use this in a project. When can you review it? This has been blocked for almost seven months now. :(

@valadas
Copy link
Member Author

valadas commented Nov 28, 2022

Done, will publish a beta now to test consumption before the official release

@valadas valadas closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants