Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Delete, Delete the Document File Too #17

Open
meffj00 opened this issue Nov 29, 2021 · 6 comments
Open

On Delete, Delete the Document File Too #17

meffj00 opened this issue Nov 29, 2021 · 6 comments

Comments

@meffj00
Copy link

meffj00 commented Nov 29, 2021

We are using the latest DNN Document module on our sites with DNN platform 9.2.2. installed.

A problem with that module is, when users delete the document entry in the module goes well, but the fysical document is not deleted.

My question is het possible to ask the user if he also want to delete the fysical document on the disk at the server?

@WillStrohl
Copy link
Member

The reason this is not yet implemented as a feature is that it's not easy to be able to know if other people have also linked to the document you're deleting. If you don't have HTTP 404 errors properly trapped, it could result in an undesirable user experience for your end-users.

However, I can see this being a useful new feature. :)

Side Note: I was able to duplicate the current behavior on DNN Platform 09.10.02.

@WillStrohl WillStrohl changed the title Physical delete document On Delete, Delete the Physical Document Too Dec 1, 2021
@WillStrohl WillStrohl changed the title On Delete, Delete the Physical Document Too On Delete, Delete the Document File Too Dec 1, 2021
@MaiklT
Copy link

MaiklT commented Apr 1, 2022

The real problem is that Google still finds the document when it is already in the search index, so someone who searches for something on Google can find an outdated or invalid document - which can be really annoying, esp. if you have some juridical or legal information in the document. Same thing happens when you change the document (upload a new version for example with a different file name) in an existing record.

The feature could be really useful, but I understand Will's objection.

A workaround for this was the old Digital Assets Manager to delete the old files as well - but this is to avoid because of Telerik dependencies. The new Resource Manager does not provide the needed functionality (see Resource Manager - "limit" access in the Community forums).

Could it be a solution to provide an alert saying "Shall the unlinked document be deleted as well?"?

@WillStrohl
Copy link
Member

Honestly, I was just trying to help think this through. I think a useful update would be to allow the delete of the document record, but include a checkbox that says something like, "Permanently Delete the File Too?" which will delete the file, but only if checked.

@MaiklT
Copy link

MaiklT commented Aug 17, 2022

Deleting is only one aspect. The other one is that someone uploads a new version of the document with a different file name. Also in this case there should be the possibility to delete the old version (by a checkbox, by a confirmation popup, whatever...).

@WillStrohl
Copy link
Member

Interesting. This also sounds like a more advanced use case.

@meffj00
Copy link
Author

meffj00 commented Jul 30, 2023

I would like to respondent. The document to be deleted is on an our intranet and cannot yet be accessed by a search engine (Google, Bing, etc.). That is why I also advocate making this function adjustable. Users upload new versions of documents with a different name. The old documents remain on the server, which is very undesirable in the context of pollution. The internal search engine also finds the documents. In addition, I don't want/can't give users permissions in the file manager to delete documents. Doing nothing is the worst solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants