Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用 SSRF 防护,取消 ALLOW_USER_SUPPLY_UNSAFE_DOMAIN #16906

Closed
1 task done
ttttmr opened this issue Sep 24, 2024 · 1 comment
Closed
1 task done

使用 SSRF 防护,取消 ALLOW_USER_SUPPLY_UNSAFE_DOMAIN #16906

ttttmr opened this issue Sep 24, 2024 · 1 comment
Labels
RSS enhancement New feature or request to existing RSS

Comments

@ttttmr
Copy link
Contributor

ttttmr commented Sep 24, 2024

这是一个什么样的功能?

ALLOW_USER_SUPPLY_UNSAFE_DOMAIN 本意应该是预防 SSRF 问题,也会导致公开实例上难以开启相关路由

可以使用 SSRF 防护,屏蔽私有地址

这个功能可以解决什么问题?

公开实例上可以安全开启全部路由

额外描述

参考:https://github.com/hanover-computing/got-ssrf

这不是重复的功能请求和 RSS 提案

@ttttmr ttttmr added the RSS enhancement New feature or request to existing RSS label Sep 24, 2024
@TonyRL
Copy link
Collaborator

TonyRL commented Nov 26, 2024

Please take a deep look at GHSA-64wp-jh9p-5cg2 and GHSA-3p3p-cgj7-vgw3. It's talking about arbitrary targets not just those inside internal network.

Originally posted by TonyRL in #16908 (review)

Again, this hasn't addressed the concern of allowing visiting arbitrary targets.

Consider an attacker asks RSSHub (which is hosted in a typical data centre) to visit https://example.com/VERY_LARGE_FILE, even with request timeout of 30s, it is still wasting unnecessary bandwidth and memory of ~3GB (assuming a gigabit here but most basic $5/mo servers can reach more than a gigabits).

Originally posted by TonyRL in #16908 (review)

@TonyRL TonyRL closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RSS enhancement New feature or request to existing RSS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants