Skip to content

Commit

Permalink
Désactive les ancres de thématiques lorsqu'on est sur l'onglet "Notes" (
Browse files Browse the repository at this point in the history
#483)

* disable anchor links when on notes tab

* update changelog
  • Loading branch information
bellangerq authored Sep 29, 2023
1 parent 62639c6 commit 0d1484a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions confiture-web-app/src/assets/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Tous les changements notables de Ara sont documentés ici avec leur date, leur c
### Corrections 🐛

- Si l’URL du site n’est pas renseignée, utilise l’URL de la première page auditée ([#487](https://github.com/DISIC/Ara/pull/487))
- Corrige le problème de disparition d’onglet lorsqu’on utilise les ancres depuis l’onglet "Notes" lors de la génération ([#483](https://github.com/DISIC/Ara/pull/483))

## 08/09/2023

Expand Down
7 changes: 5 additions & 2 deletions confiture-web-app/src/components/AuditGenerationFilters.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script setup lang="ts">
import { computed, watch, nextTick } from "vue";
import { ref } from "vue";
import { useFiltersStore, useResultsStore } from "../store";
import { useAuditStore, useFiltersStore, useResultsStore } from "../store";
import { pluralize } from "../utils";
defineProps<{
Expand All @@ -14,6 +14,7 @@ const emit = defineEmits<{
const filterStore = useFiltersStore();
const resultStore = useResultsStore();
const auditStore = useAuditStore();
const resultsCount = computed(() =>
filterStore.filteredTopics
Expand Down Expand Up @@ -183,8 +184,10 @@ watch(
:style="{ '--topic-filter-value': topic.value + '%' }"
>
<a
:href="`#${topic.number}`"
:href="auditStore.currentPageId ? `#${topic.number}` : undefined"
class="fr-py-1w fr-px-1w fr-mb-2v topic-filter-anchor"
:aria-disabled="auditStore.currentPageId ? undefined : 'true'"
:role="auditStore.currentPageId ? undefined : 'link'"
>
<span>{{ topic.number }}.</span>
<span>{{ topic.title }}</span>
Expand Down

0 comments on commit 0d1484a

Please sign in to comment.