-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] feat(Resources): introduce fabric in SSHCE #7703
base: integration
Are you sure you want to change the base?
Conversation
206c55e
to
6fbeaed
Compare
Just a note: we do not (yet) have a way to do proper integration test for the Computing Elements, but one may think about adding them to our integration tests setup. Something to think about it, it would be nice if it was in this PR. |
6fbeaed
to
1c60e47
Compare
I agree it would great to add integration tests for CEs, at least to test basic features. But it will likely become complex because:
I will give it a try with the |
I wonder if it really makes sense to add CEs (and Batch Systems) in the integration tests: while it would be great to have a "grid in a box" in a controller environment, it would be cumbersome to maintain on the long term and would not be representative of all the instances we can find out there (e.g. Arc v6, v6 with a hack, v7, transferring jobs to Slurm, HTCondor, SSH, SSH tunnel, HTCondor with local scheduler, with remote scheduler...). It would probably make more sense to add some scripts to run during the hackathons. For each type of CE supported it would:
Basically, it would be very similar to (i) submitting pilots with the Site Director and (ii) checking their results manually. But it would be more focused on the CE interfaces and would be more automated (though a human would need to check whether errors come from the CE instance itself or the Dirac CE interface). Any opinion @fstagni ? |
I think the only one that would make sense to set up here is the SSHCE. The others, "proper Grid ones", can not be tested here. |
I don't even know if testing SSHCE in an integration test makes sense. The only easy test we can set up would be |
OK OK, give up on the idea... |
I will add a certification test focused on the CE interfaces as I explained (+ a card in the kanban board to explain how to execute it). I will execute it in the lhcb environment to make sure the changes in this PR are correct. And I can also try to add a container that would act as a "Site" and use |
Sure, thanks |
Replace the Dirac-specific
SSH
class byfabric
.BEGINRELEASENOTES
*Resources
CHANGE: Replace SSH by fabric in SSHComputingElement
ENDRELEASENOTES