Skip to content

Commit

Permalink
Bugfix and update versions
Browse files Browse the repository at this point in the history
  • Loading branch information
joeranbosma committed Oct 10, 2024
1 parent 84fb860 commit 54c8bd4
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 18 deletions.
14 changes: 7 additions & 7 deletions requirements_dev.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
flake8==3.9.2
tox==3.24.3
pytest==6.2.5
pytest-cov==2.12.1
mypy===0.910
flake8==7.1.1
tox==4.18.1
pytest==8.3.2
pytest-cov==5.0.0
mypy===1.11.2
build==1.2.2
twine==5.1.1
gcapi
build
twine
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ classifiers =
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12

[options]
packages =
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def run(self):
long_description = fh.read()

setuptools.setup(
version='1.4.8', # also update version in metrics.py -> version
version='1.4.9', # also update version in metrics.py -> version
author_email='[email protected]',
long_description=long_description,
long_description_content_type="text/markdown",
Expand Down
2 changes: 1 addition & 1 deletion src/picai_eval/eval.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def evaluate_case(
overlap = overlap_matrix[lesion_id, lesion_candidate_id]
overlap -= 1 # return overlap to [0, 1]

assert overlap > min_overlap, "Overlap must be greater than min_overlap!"
assert overlap >= min_overlap, "Overlap must be at least `min_overlap`!"

y_list.append((1, lesion_confidence, overlap))

Expand Down
4 changes: 2 additions & 2 deletions tests/Development-README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ AutoPEP8 for formatting (this can be done automatically on save, see e.g. https:
# Push release to PyPI
1. Increase version in setup.py, and set below
2. Build: `python -m build`
3. Test package distribution: `python -m twine upload --repository testpypi dist/*1.4.3*`
4. Distribute package to PyPI: `python -m twine upload dist/*1.4.3*`
3. Test package distribution: `python -m twine upload --repository testpypi dist/*1.4.9*`
4. Distribute package to PyPI: `python -m twine upload dist/*1.4.9*`
11 changes: 4 additions & 7 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
[tox]
minversion = 3.8.0
envlist = py36, py37, py38, py39, flake8
envlist = py38, py312, flake8
isolated_build = true

[gh-actions]
python =
3.6: py36
3.7: py37
3.8: py38
3.9: py39, flake8
3.12: py312, flake8

[testenv]
setenv =
Expand All @@ -19,13 +17,12 @@ commands =
pytest --basetemp={envtmpdir}

[testenv:flake8]
basepython = python3.9
basepython = python3.12
deps = flake8
commands = flake8 src tests

[testenv:mypy]
basepython = python3.9
basepython = python3.12
deps =
-r{toxinidir}/requirements_dev.txt
commands = mypy src

0 comments on commit 54c8bd4

Please sign in to comment.