Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please merge it with Profile tools plugin #3

Open
pcav opened this issue Oct 11, 2014 · 0 comments
Open

Please merge it with Profile tools plugin #3

pcav opened this issue Oct 11, 2014 · 0 comments

Comments

@pcav
Copy link

pcav commented Oct 11, 2014

Consideration from an email exchange.

Well, as both plugins share the same (or almost the same) dock widget, I'd
prefer to merge them into one: the two separate QActions could
call the shared widget and connect a different map tool to it.

Now, as the GUI is the heart of both plugins, the majority of the code is
duplicated (I assume the only unique part is the map tool and some code to
populate the graph). Furthermore, IMHO the GUI is still far from being
perfect, so I could expect some improvements in the future, that should be
ideally adopted by both tools anyhow.

So I have no objections against keeping them separate for now, however I'd
consider merging them at some point. Furthermore, some day we could even merge
the Value Tool into one complex raster query tool. Of course the last case
should be discussed in order to avoid dropping the handy and minimalistic
widget of Value tool (maybe "simple" and "advanced" versions of the GUI?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant