You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The console will hang if the user makes a typo in the console while lua is busy
reproduction:
in the launcher, do lua "while(true) do end" (which tosses lua into an infinite loop)
in the console, type any invalid command and hit enter
the console will deadlock
The text was updated successfully, but these errors were encountered:
I believe this is caused by the "invalid command" handler calling into help_helper to display help, which requires acquiring a CoreSuspender. We should use a nonblocking lock acquisition approach here and cause help_helper to downgrade gracefully if it cannot acquire a CoreSuspender instead of deadlocking the console.
ab9rf
added a commit
to ab9rf/dfhack
that referenced
this issue
Dec 3, 2024
this is an attempted step to improve semantics around core suspenders. this does not actually resolveDFHack#5074 but it is intended as a step toward doing so
ab9rf
linked a pull request
Dec 3, 2024
that will
close
this issue
this is an attempted step to improve semantics around core suspenders. this does not actually resolveDFHack#5074 but it is intended as a step toward doing so
The console will hang if the user makes a typo in the console while lua is busy
reproduction:
in the launcher, do
lua "while(true) do end"
(which tosses lua into an infinite loop)in the console, type any invalid command and hit enter
the console will deadlock
The text was updated successfully, but these errors were encountered: