#5031: Fix accessibility logic for wagons #5053
Conversation
|
Apparently I may have worked on a separate problem that I saw. After re-reading the issue, if dfhack claims wagon is accessible when it is not, then this doesn't fix that. Back to the start on this one -- though I still think these changes may be wanted |
|
Marked as draft temporarily. |
…rectly reporting wagon accessibility
|
The first four commits deal with what I perceive to be an issue with how down ramps are handled. Without those commits, we get X's on the down ramps, but not on the up ramps. The lack of symmetry is odd. However, it probably doesn't belong in this PR - especially the change in Maps. The down ramp appearance change in pathable will, iirc, visually make down ramps appear accessible for wagons. I believe the change in maps was to do the same for 'follow mouse' in gui/pathable. I think I am done with this pending review |
dhthwy
changed the title
dhthwy
changed the title
Fixes #5031
The save for 5031 has down stairs blocking the wagon path. This PR attempts more robust wagon accessibility handling.
Other issues:
There is also an issue with the 'follow mouse' functionality where walkability is being correctly set for top ramps. This causes the UI to erroneously display an 'X' over the ramp tile, incorrectly indicating that the tile (or the z-level below) is inaccessible.
I am unsure about tests for this.
Me, from elsewhere:
"It looks like walkable is computed by df, right? The down ramp itself is not walkable. I suspect we'll have to special case ramps in Maps and have it tie its walkability group to an adjacent tiles group" AND ensure the tile below the ramp also matches the group of its adjacent tile.
Assumed invariant: adjacent tiles belong to the same walkability group.