Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspend manager thinks floor bars block wall when opposite is true #3074

Closed
drewcassidy opened this issue Mar 23, 2023 · 7 comments · Fixed by DFHack/scripts#648
Closed

Suspend manager thinks floor bars block wall when opposite is true #3074

drewcassidy opened this issue Mar 23, 2023 · 7 comments · Fixed by DFHack/scripts#648
Assignees
@plule

Comments

@drewcassidy
Copy link

drewcassidy commented Mar 23, 2023 •
edited
Loading

Suspend manager is suspending these floor bars, I think because it thinks they would block the adjacent walls, when in fact the walls are impossible to construct WITHOUT the floor bars
image

Save: https://pileof.rocks/barswtf.zip
mods:
mods.zip

As discussed in Discord, sounds like this is an issue with building:isImpassableAtCreation()
@drewcassidy drewcassidy closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
@myk002
Copy link
Member

myk002 commented Mar 23, 2023

did this turn out to not be an issue?

@drewcassidy
Copy link
Author

drewcassidy commented Mar 23, 2023 •
edited
Loading

Different issue as discussed on Discord, will open a new issue now that I know its not as simple as I thought See update

@myk002
Copy link
Member

myk002 commented Mar 23, 2023

discord discussion link: https://discord.com/channels/793331351645323264/807444467140788254/1088341251008516178

@myk002 myk002 reopened this Mar 23, 2023
@myk002 myk002 added this to 50.07-r1 Mar 23, 2023
@myk002
Copy link
Member

myk002 commented Mar 23, 2023

@plule

@github-project-automation github-project-automation bot moved this to Todo in 50.07-r1 Mar 23, 2023
@plule
Copy link
Contributor

plule commented Mar 23, 2023

List of building to take in account:

  • wall
  • fortification
  • windows
  • floodgates
  • vertical bars
  • wall grates
  • statues
  • gear assemblies? (Double check if passable)

@ab9rf
Copy link
Member

ab9rf commented Mar 23, 2023

see also DFHack/df-structures#586

@ab9rf
Copy link
Member

ab9rf commented Mar 23, 2023

will also note that in a playthrough earlier this evening i had suspendmanager behave badly with respect to constructing two adjacent bridges; this behavior would be explained by it incorrectly thinking bridges are impassible at construction

@myk002 myk002 moved this from Todo to In Progress in 50.07-r1 Mar 23, 2023
@plule plule mentioned this issue Mar 23, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in 50.07-r1 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plule plule

Labels
None yet
Projects
No open projects
50.07-r1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suspendmanager: Fix suspending floor grates, bridges and others plule/scripts-1
4 participants
@plule @myk002 @ab9rf @drewcassidy