Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"value_type" aka. Unit beliefs, is named a bit ambiguously #473

Open
cppcooper opened this issue Sep 18, 2022 · 0 comments
Open

"value_type" aka. Unit beliefs, is named a bit ambiguously #473

cppcooper opened this issue Sep 18, 2022 · 0 comments

Comments

@cppcooper
Copy link

cppcooper commented Sep 18, 2022

df-structures/df.units.xml

Lines 146 to 151 in a04727c

<enum-type type-name='value_type'>
<enum-item name='NONE' value='-1'/>
<enum-item name='LAW'/>
<enum-item name='LOYALTY'/>
<enum-item name='FAMILY'/>

It would be nice if this was named similar to the wiki article, if only for the sake of searchability.

edit: as per discord discussion, the game seems to refer to this system as a value system. @Ozzatron arrived on personality_value_type as an alternative to simply value_type

@cppcooper cppcooper changed the title Unit beliefs, aka "value_type" "value_type" aka. Unit beliefs, is named a bit ambiguously Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant