From 330e00cb13056e97403d5e04adab3e7392e6051b Mon Sep 17 00:00:00 2001
From: ThomasWhittington <46750921+ThomasWhittington@users.noreply.github.com>
Date: Thu, 5 Sep 2024 13:53:52 +0100
Subject: [PATCH] "Bits and Bats". Required changes for plantech integration
 (#158)

* feat: changed header logo to go to self-assessment (#153)

Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk>

* Fix/bleeding links (#154)

* fix: feedback link fixed

* Fix: Fixed bleeding links

---------

Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk>

* fix: added missing span from feedback banner

* feature: setup to use plantechs head and cookies when ran with it (#156)

* feature: setup to use plantechs head and cookies when ran with it

* fix: added a title to the gtm iframe

* chore: using index reference rather than .First

---------

Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk>

---------

Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk>
---
 .../_CookieBanner.cshtml}                     |  0
 .../Views/Shared/RichText/_HyperLink.cshtml   |  6 +--
 .../Views/Shared/_BetaHeader.cshtml           |  9 ++--
 .../Views/Shared/_BodyEnd.cshtml              |  4 ++
 .../Views/Shared/_CsBeforeContent.cshtml      | 10 ++++
 .../Views/Shared/_CsHeader.cshtml             | 26 +++++----
 .../Views/Shared/_CsLayout.cshtml             | 54 +++----------------
 .../Views/Shared/_Head.cshtml                 | 14 +++++
 8 files changed, 56 insertions(+), 67 deletions(-)
 rename src/Dfe.ContentSupport.Web/Views/Shared/{_CookieConsent.cshtml => CookiesBanner/_CookieBanner.cshtml} (100%)
 create mode 100644 src/Dfe.ContentSupport.Web/Views/Shared/_BodyEnd.cshtml
 create mode 100644 src/Dfe.ContentSupport.Web/Views/Shared/_CsBeforeContent.cshtml
 create mode 100644 src/Dfe.ContentSupport.Web/Views/Shared/_Head.cshtml

diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/_CookieConsent.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/CookiesBanner/_CookieBanner.cshtml
similarity index 100%
rename from src/Dfe.ContentSupport.Web/Views/Shared/_CookieConsent.cshtml
rename to src/Dfe.ContentSupport.Web/Views/Shared/CookiesBanner/_CookieBanner.cshtml
diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/RichText/_HyperLink.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/RichText/_HyperLink.cshtml
index 46be2f8..ab2f610 100644
--- a/src/Dfe.ContentSupport.Web/Views/Shared/RichText/_HyperLink.cshtml
+++ b/src/Dfe.ContentSupport.Web/Views/Shared/RichText/_HyperLink.cshtml
@@ -2,11 +2,9 @@
 
 @if (Model.IsVimeo)
 {
-    <partial name="RichText/_Vimeo" model="@Model" />
+    <partial name="RichText/_Vimeo" model="@Model"/>
 }
 else
 {
-    <a href="@Model.Uri" target="_blank" rel="noopener noreferrer">
-        <partial name="RichText/_Items" model="@Model"/>
-    </a>
+    <a href="@Model.Uri" target="_blank" rel="noopener noreferrer"><partial name="RichText/_Text" model="@Model.Content[0]"/></a>
 }
\ No newline at end of file
diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/_BetaHeader.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/_BetaHeader.cshtml
index 70580a5..b39601a 100644
--- a/src/Dfe.ContentSupport.Web/Views/Shared/_BetaHeader.cshtml
+++ b/src/Dfe.ContentSupport.Web/Views/Shared/_BetaHeader.cshtml
@@ -2,11 +2,8 @@
     <p class="govuk-phase-banner__content">
         @* <govuk-phase-banner-tag>Beta</govuk-phase-banner-tag> *@
         <strong class="govuk-tag govuk-phase-banner__content__tag">Beta</strong>
-        This is a new service - your
-        <a href="https://forms.office.com/e/Jk5PuNWvGe" class="govuk-link" target="_blank"
-        rel="noopener">
-            feedback
-        </a> will
-        help us to improve it.
+        <span class="govuk-phase-banner__text">
+            This is a new service - your <a href="https://forms.office.com/e/Jk5PuNWvGe" class="govuk-link" target="_blank" rel="noopener">feedback</a> will help us to improve it.
+        </span>
     </p>
 </div>
\ No newline at end of file
diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/_BodyEnd.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/_BodyEnd.cshtml
new file mode 100644
index 0000000..49f78dd
--- /dev/null
+++ b/src/Dfe.ContentSupport.Web/Views/Shared/_BodyEnd.cshtml
@@ -0,0 +1,4 @@
+<script defer type="module" nonce="@Context.Items["nonce"]">
+    import * as govuk from '/js/govuk-frontend.min.js';
+    govuk.initAll();
+</script>
diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/_CsBeforeContent.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/_CsBeforeContent.cshtml
new file mode 100644
index 0000000..6d28fe4
--- /dev/null
+++ b/src/Dfe.ContentSupport.Web/Views/Shared/_CsBeforeContent.cshtml
@@ -0,0 +1,10 @@
+@using Dfe.ContentSupport.Web.Configuration
+@inject TrackingOptions TrackingOptions
+
+<!-- Google Tag Manager (noscript) -->
+<noscript>
+    <iframe src=@($"https://www.googletagmanager.com/ns.html?id={TrackingOptions.Gtm}") height="0" width="0"
+            style="display:none;visibility:hidden" title="cs_gtm">
+    </iframe>
+</noscript>
+<!-- End Google Tag Manager (noscript) -->
diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/_CsHeader.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/_CsHeader.cshtml
index 0fb2a92..25d3b2c 100644
--- a/src/Dfe.ContentSupport.Web/Views/Shared/_CsHeader.cshtml
+++ b/src/Dfe.ContentSupport.Web/Views/Shared/_CsHeader.cshtml
@@ -1,13 +1,17 @@
-<div class="dfe-header">
-    <div class="dfe-width-container dfe-header__container">
-        <div class="dfe-header__logo">
-            <a class="dfe-header__link dfe-header__link--service " href="/" aria-label="DfE homepage">
-                <img src="/assets/images/dfe-logo.png" class="dfe-logo" alt="DfE Homepage">
-                <img src="/assets/images/dfe-logo-alt.png" class="dfe-logo-hover" alt="DfE Homepage">
-            </a>
+<header role="banner">
+    <partial name="CookiesBanner/_CookieBanner" />
+    <div class="dfe-header">
+        <div class="dfe-width-container dfe-header__container">
+            <div class="dfe-header__logo">
+                <a class="dfe-header__link dfe-header__link--service " href="/" aria-label="DfE homepage">
+                    <img src="/assets/images/dfe-logo.png" class="dfe-logo" alt="DfE Homepage">
+                    <img src="/assets/images/dfe-logo-alt.png" class="dfe-logo-hover" alt="DfE Homepage">
+                </a>
+            </div>
+        </div>
+        <div class="dfe-width-container dfe-header__service-name">
+            <a href="/self-assessment" class="dfe-header__link--service">Plan technology for your school</a>
         </div>
     </div>
-    <div class="dfe-width-container dfe-header__service-name">
-        <a href="/self-assessment" class="dfe-header__link--service">Plan technology for your school</a>
-    </div>
-</div>
\ No newline at end of file
+    <partial name="_Hero" model="@Model.Heading"/>
+</header>
diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/_CsLayout.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/_CsLayout.cshtml
index fa842bf..d6b4001 100644
--- a/src/Dfe.ContentSupport.Web/Views/Shared/_CsLayout.cshtml
+++ b/src/Dfe.ContentSupport.Web/Views/Shared/_CsLayout.cshtml
@@ -1,64 +1,30 @@
-@using Dfe.ContentSupport.Web.Configuration
-@inject TrackingOptions TrackingOptions
 @model CsPage;
 
 @{
     Layout = "_GovUkPageTemplate";
     ViewData["Title"] = Model.Heading.Title;
     ViewData["containerClasses"] = "dfe-width-container";
-    var consentCookie = Context.Request.Cookies[".AspNet.Consent"];
-    var track = consentCookie == "true";
 }
 
 @section Head {
-    @{
-        if (track)
-        {
-            <!-- Google Tag Manager -->
-            <script>(function (w, d, s, l, i) {
-                    w[l] = w[l] || []; w[l].push({
-                        'gtm.start':
-                            new Date().getTime(), event: 'gtm.js'
-                    }); var f = d.getElementsByTagName(s)[0],
-                        j = d.createElement(s), dl = l != 'dataLayer' ? '&l=' + l : ''; j.async = true; j.src =
-                            'https://www.googletagmanager.com/gtm.js?id=' + i + dl; f.parentNode.insertBefore(j, f);
-                })(window, document, 'script', 'dataLayer', '@(TrackingOptions.Gtm)');</script>
-            <!-- End Google Tag Manager -->
-        }
-    }
+    <partial name="_Head"/>
 }
 
 @section Header {
     <link rel="stylesheet" as="style" href="~/css/application.css">
     <link rel="stylesheet" as="style" href="~/css/cands-site.css">
-    <header role="banner">
-        <partial name="_CookieConsent"/>
-        <partial name="_CsHeader"/>
-        <partial name="_Hero" model="@Model.Heading"/>
-    </header>
-    @RenderSection("Header", false)
+    <partial name="_CsHeader"/>
+    @await RenderSectionAsync("Header", false)
 }
 
 @section BeforeContent {
     <script
         defer>document.body.className += ' js-enabled' + ('noModule' in HTMLScriptElement.prototype ? ' govuk-frontend-supported' : '');</script>
-
-    @{
-        if (track)
-        {
-            <!-- Google Tag Manager (noscript) -->
-            <noscript>
-                <iframe src=@($"https://www.googletagmanager.com/ns.html?id={TrackingOptions.Gtm}") height="0" width="0"
-                        style="display:none;visibility:hidden">
-                </iframe>
-            </noscript>
-            <!-- End Google Tag Manager (noscript) -->
-        }
-    }
-
-    @RenderSection("BeforeContent", false)
+    <partial name="_CsBeforeContent"/>
+    @await RenderSectionAsync("BeforeContent", false)
 }
 
+
 @RenderBody()
 
 @section Footer {
@@ -66,10 +32,6 @@
 }
 
 @section BodyEnd {
-    <script defer type="module" nonce="@Context.Items["nonce"]">
-        import * as govuk from '/js/govuk-frontend.min.js';
-        govuk.initAll();
-    </script>
-
-    @RenderSection("BodyEnd", false)
+    <partial name="_BodyEnd"/>
+    @await RenderSectionAsync("BodyEnd", false)
 }
\ No newline at end of file
diff --git a/src/Dfe.ContentSupport.Web/Views/Shared/_Head.cshtml b/src/Dfe.ContentSupport.Web/Views/Shared/_Head.cshtml
new file mode 100644
index 0000000..afc694d
--- /dev/null
+++ b/src/Dfe.ContentSupport.Web/Views/Shared/_Head.cshtml
@@ -0,0 +1,14 @@
+@using Dfe.ContentSupport.Web.Configuration
+@inject TrackingOptions TrackingOptions
+
+
+<!-- Google Tag Manager -->
+<script>(function (w, d, s, l, i) {
+                    w[l] = w[l] || []; w[l].push({
+                        'gtm.start':
+                            new Date().getTime(), event: 'gtm.js'
+                    }); var f = d.getElementsByTagName(s)[0],
+                        j = d.createElement(s), dl = l != 'dataLayer' ? '&l=' + l : ''; j.async = true; j.src =
+                            'https://www.googletagmanager.com/gtm.js?id=' + i + dl; f.parentNode.insertBefore(j, f);
+                })(window, document, 'script', 'dataLayer', '@(TrackingOptions.Gtm)');</script>
+<!-- End Google Tag Manager -->
\ No newline at end of file