From da5d1b57c88e727c0904443b3e6db5132d75ea77 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 1 Jul 2024 03:51:23 +0000 Subject: [PATCH 1/2] Bump rubocop-rails from 2.25.0 to 2.25.1 Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.25.0 to 2.25.1. - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.25.0...v2.25.1) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index fc1f162b21..28164ae60d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -433,7 +433,7 @@ GEM matrix (0.4.2) method_source (1.1.0) mini_mime (1.1.5) - minitest (5.24.0) + minitest (5.24.1) mock_redis (0.44.0) msgpack (1.7.2) multi_json (1.15.0) @@ -658,7 +658,7 @@ GEM rubocop (~> 1.41) rubocop-factory_bot (2.26.1) rubocop (~> 1.61) - rubocop-rails (2.25.0) + rubocop-rails (2.25.1) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) From 42d42f9ad46e824a795e8ce00792ce83c4ab77fe Mon Sep 17 00:00:00 2001 From: David Young Date: Tue, 2 Jul 2024 12:50:39 +0100 Subject: [PATCH 2/2] Ignores Rails/BulkChangeTable in previous migrations --- ...5339_change_application_start_and_end_date_to_not_null.rb | 2 ++ .../20190909105439_provider_enrichment_user_not_null.rb | 5 ++++- db/migrate/20210317141543_add_not_null_to_user.rb | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/db/migrate/20190815095339_change_application_start_and_end_date_to_not_null.rb b/db/migrate/20190815095339_change_application_start_and_end_date_to_not_null.rb index 466ea9009a..86bd1dd6cd 100644 --- a/db/migrate/20190815095339_change_application_start_and_end_date_to_not_null.rb +++ b/db/migrate/20190815095339_change_application_start_and_end_date_to_not_null.rb @@ -2,7 +2,9 @@ class ChangeApplicationStartAndEndDateToNotNull < ActiveRecord::Migration[5.2] def change + # rubocop:disable Rails/BulkChangeTable change_column_null :recruitment_cycle, :application_start_date, false change_column_null :recruitment_cycle, :application_end_date, false + # rubocop:enable Rails/BulkChangeTable end end diff --git a/db/migrate/20190909105439_provider_enrichment_user_not_null.rb b/db/migrate/20190909105439_provider_enrichment_user_not_null.rb index 4524ee811f..cb645c38e4 100644 --- a/db/migrate/20190909105439_provider_enrichment_user_not_null.rb +++ b/db/migrate/20190909105439_provider_enrichment_user_not_null.rb @@ -14,13 +14,16 @@ def up pe.updated_by_user_id = some_id pe.save! end - + # rubocop:disable Rails/BulkChangeTable change_column_null :provider_enrichment, :updated_by_user_id, false change_column_null :provider_enrichment, :created_by_user_id, false + # rubocop:enable Rails/BulkChangeTable end def down + # rubocop:disable Rails/BulkChangeTable change_column_null :provider_enrichment, :updated_by_user_id, true change_column_null :provider_enrichment, :created_by_user_id, true + # rubocop:enable Rails/BulkChangeTable end end diff --git a/db/migrate/20210317141543_add_not_null_to_user.rb b/db/migrate/20210317141543_add_not_null_to_user.rb index 88749dee7b..1fe830e8c9 100644 --- a/db/migrate/20210317141543_add_not_null_to_user.rb +++ b/db/migrate/20210317141543_add_not_null_to_user.rb @@ -2,7 +2,9 @@ class AddNotNullToUser < ActiveRecord::Migration[6.1] def change + # rubocop:disable Rails/BulkChangeTable change_column_null(:user, :first_name, false) change_column_null(:user, :last_name, false) + # rubocop:enable Rails/BulkChangeTable end end