From cf8765b598c9956a42cddbd7fa6bd588bfd55859 Mon Sep 17 00:00:00 2001
From: James Gunn <james@gunn.io>
Date: Thu, 4 Jan 2024 10:08:46 +0000
Subject: [PATCH] Make sure invisible buttons can't be focused by keyboard

---
 .../Pages/SignIn/Register/NiNumberPage.cshtml                   | 2 +-
 .../Pages/SignIn/Register/Phone.cshtml                          | 2 +-
 .../Pages/SignIn/Register/PhoneConfirmation.cshtml              | 2 +-
 .../Pages/SignIn/Register/TrnPage.cshtml                        | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/NiNumberPage.cshtml b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/NiNumberPage.cshtml
index d6705ae55..8ad385610 100644
--- a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/NiNumberPage.cshtml
+++ b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/NiNumberPage.cshtml
@@ -16,7 +16,7 @@
             </govuk-input>
 
             @* Pressing the Enter key will submit the first submit button - make sure it's the default action *@
-            <button type="submit" class="govuk-!-display-none"></button>
+            <button type="submit" class="govuk-!-display-none" tabindex="-1"></button>
 
             <govuk-details>
                 <govuk-details-summary>
diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/Phone.cshtml b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/Phone.cshtml
index b4922ce06..3d91d4df2 100644
--- a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/Phone.cshtml
+++ b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/Phone.cshtml
@@ -23,7 +23,7 @@
                 label-class="govuk-label--s" />
 
             @* Pressing the Enter key will submit the first submit button - make sure it's the default action *@
-            <button type="submit" class="govuk-!-display-none"></button>
+            <button type="submit" class="govuk-!-display-none" tabindex="-1"></button>
 
             <govuk-details>
                 <govuk-details-summary>I do not have access to a mobile phone</govuk-details-summary>
diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/PhoneConfirmation.cshtml b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/PhoneConfirmation.cshtml
index 103252a43..49c9d89e8 100644
--- a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/PhoneConfirmation.cshtml
+++ b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/PhoneConfirmation.cshtml
@@ -24,7 +24,7 @@
                 label-class="govuk-label--s" />
 
             @* Pressing the Enter key will submit the first submit button - make sure it's the default action *@
-            <button type="submit" class="govuk-!-display-none"></button>
+            <button type="submit" class="govuk-!-display-none" tabindex="-1"></button>
 
             <govuk-details>
                 <govuk-details-summary>I have not received a code</govuk-details-summary>
diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/TrnPage.cshtml b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/TrnPage.cshtml
index 5d27e0532..394d26906 100644
--- a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/TrnPage.cshtml
+++ b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/SignIn/Register/TrnPage.cshtml
@@ -24,7 +24,7 @@
                 label-class="govuk-label--s"/>
 
             @* Pressing the Enter key will submit the first submit button - make sure it's the default action *@
-            <button type="submit" class="govuk-!-display-none"></button>
+            <button type="submit" class="govuk-!-display-none" tabindex="-1"></button>
 
             @if (Model.ShowContinueWithoutTrnButton)
             {