+ <%= dashboard_link('all', 'All') %>
+ |
+ <%= dashboard_link('sept_oct', 'Sept/Oct 2023') %>
+ |
+ <%= dashboard_link('jan_feb', 'Jan/Feb 2024') %>
+
+
Applications
diff --git a/config/environments/development.rb b/config/environments/development.rb
index c2563f66..7341ed86 100644
--- a/config/environments/development.rb
+++ b/config/environments/development.rb
@@ -61,4 +61,6 @@
# Uncomment if you wish to allow Action Cable access from any origin.
# config.action_cable.disable_request_forgery_protection = true
+
+ config.hosts << "itrp.local"
end
diff --git a/config/environments/test.rb b/config/environments/test.rb
index 58fa5bad..a13e8607 100644
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -54,4 +54,6 @@
# config/initializers/dartsass.rb
config.dartsass.build_options << " --quiet-deps"
+
+ config.hosts << "www.example.com"
end
diff --git a/spec/helpers/inflection_helper_spec.rb b/spec/helpers/inflection_helper_spec.rb
new file mode 100644
index 00000000..6b540f31
--- /dev/null
+++ b/spec/helpers/inflection_helper_spec.rb
@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe InflectionHelper do
+ it "returns singular when count is 1" do
+ expect(pluralize_word(1, "day")).to eq "1 day"
+ end
+
+ it "returns plural when count is not 1" do
+ expect(pluralize_word(0, "day")).to eq "0 days"
+ expect(pluralize_word(2, "day")).to eq "2 days"
+ expect(pluralize_word(10, "day")).to eq "10 days"
+ end
+end
diff --git a/spec/models/kpis_spec.rb b/spec/models/kpis_spec.rb
index 58abc3ed..5364bb08 100644
--- a/spec/models/kpis_spec.rb
+++ b/spec/models/kpis_spec.rb
@@ -44,21 +44,713 @@
end
describe "#total_applications" do
- before { create_list(:application, 5) }
+ before do
+ create_list(:application, 3, created_at: Date.new(2023, 9, 15))
+ create_list(:application, 2, created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns total number of applications" do
+ expect(kpis.total_applications).to eq(5)
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns total number of applications created within 'sept_oct' window" do
+ expect(kpis.total_applications).to eq(3)
+ end
+ end
- it { expect(kpis.total_applications).to eq(5) }
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns total number of applications created within 'jan_feb' window" do
+ expect(kpis.total_applications).to eq(2)
+ end
+ end
end
describe "#total_rejections" do
- before { create_list(:application_progress, 5, :rejection_completed, application:) }
+ before do
+ create_list(:application_progress, 3, :rejection_completed, application: create(:application), created_at: Date.new(2023, 9, 15))
+ create_list(:application_progress, 2, :rejection_completed, application: create(:application), created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns total number of rejections" do
+ expect(kpis.total_rejections).to eq(5)
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns total number of rejections created within 'sept_oct' window" do
+ expect(kpis.total_rejections).to eq(3)
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns total number of rejections created within 'jan_feb' window" do
+ expect(kpis.total_rejections).to eq(2)
+ end
+ end
+ end
+
+ describe "#average_age" do
+ before do
+ create(:application, applicant: create(:applicant, date_of_birth: 35.years.ago), created_at: Date.new(2023, 9, 15))
+ create(:application, applicant: create(:applicant, date_of_birth: 45.years.ago), created_at: Date.new(2023, 9, 20))
+ create(:application, applicant: create(:applicant, date_of_birth: 52.years.ago), created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns the average age of all applications" do
+ expect(kpis.average_age).to eq(44)
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns the average age of applications created in 'sept_oct' window" do
+ expect(kpis.average_age).to eq(40) # Average of first two applicants (35 and 45)
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
- it { expect(kpis.total_rejections).to eq(5) }
+ it "returns the average age of applications created within 'jan_feb' window" do
+ expect(kpis.average_age).to eq(52) # Only one applicant in this date range (52)
+ end
+ end
end
describe "#total_paid" do
- before { create_list(:application_progress, 5, :banking_approval_completed, application:) }
+ before do
+ create(:application_progress, :banking_approval_completed, application: create(:application), created_at: Date.new(2023, 9, 15))
+ create(:application_progress, :banking_approval_completed, application: create(:application), created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns total number of paid applications" do
+ expect(kpis.total_paid).to eq(2)
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns total number of paid applications" do
+ total = kpis.total_paid
+ expect(total).to eq(1)
+ sept_oct_payment = ApplicationProgress.where("extract(month from created_at) IN (?) AND banking_approval_completed_at IS NOT NULL", [9, 10]).last
+ expect(sept_oct_payment).to be_present
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns total number of paid applications" do
+ total = kpis.total_paid
+ expect(total).to eq(1)
+ jan_feb_payment = ApplicationProgress.where("extract(month from created_at) IN (?) AND banking_approval_completed_at IS NOT NULL", [1, 2]).last
+ expect(jan_feb_payment).to be_present
+ end
+ end
+ end
+
+ describe "#route_breakdown" do
+ before do
+ create_list(:teacher_application, 3, created_at: Date.new(2023, 9, 15))
+ create_list(:salaried_trainee_application, 2, created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns a breakdown of all application routes" do
+ expect(kpis.route_breakdown).to eq({ "teacher" => 3, "salaried_trainee" => 2 })
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns a breakdown of application routes created within 'sept_oct' window" do
+ expect(kpis.route_breakdown).to eq({ "teacher" => 3 })
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns a breakdown of application routes created within 'jan_feb' window" do
+ expect(kpis.route_breakdown).to eq({ "salaried_trainee" => 2 })
+ end
+ end
+ end
+
+ describe "#subject_breakdown" do
+ before do
+ create_list(:application, 3, subject: :physics, created_at: Date.new(2023, 9, 15))
+ create_list(:application, 2, subject: :languages, created_at: Date.new(2024, 1, 15))
+ create(:application, subject: :general_science, created_at: Date.new(2024, 1, 16))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns a breakdown of all application subjects" do
+ expect(kpis.subject_breakdown).to eq({ "physics" => 3, "languages" => 2, "general_science" => 1 })
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns a breakdown of application subjects created within 'sept_oct' window" do
+ expect(kpis.subject_breakdown).to eq({ "physics" => 3 })
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns a breakdown of application subjects created within 'jan_feb' window" do
+ expect(kpis.subject_breakdown).to eq({ "languages" => 2, "general_science" => 1 })
+ end
+ end
+ end
+
+ describe "#visa_breakdown" do
+ before do
+ create_list(:application, 3, visa_type: "visa_1", created_at: Date.new(2023, 9, 15))
+ create_list(:application, 2, visa_type: "visa_2", created_at: Date.new(2023, 9, 15))
+ create(:application, visa_type: "visa_3", created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns a breakdown of all application visas" do
+ expect(kpis.visa_breakdown).to contain_exactly(["visa_1", 3], ["visa_2", 2], ["visa_3", 1])
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns a breakdown of application visas created within 'sept_oct' window" do
+ expect(kpis.visa_breakdown).to contain_exactly(["visa_1", 3], ["visa_2", 2])
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns a breakdown of application visas created within 'jan_feb' window" do
+ expect(kpis.visa_breakdown).to contain_exactly(["visa_3", 1])
+ end
+ end
+ end
+
+ describe "#nationality_breakdown" do
+ before do
+ create_list(:application, 3, applicant: create(:applicant, nationality: "Nationality 1"), created_at: Date.new(2023, 9, 15))
+ create(:application, applicant: create(:applicant, nationality: "Nationality 2"), created_at: Date.new(2023, 9, 15))
+ create_list(:application, 2, applicant: create(:applicant, nationality: "Nationality 3"), created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns a breakdown of all application nationalities" do
+ expect(kpis.nationality_breakdown).to contain_exactly(["Nationality 1", 3], ["Nationality 2", 1], ["Nationality 3", 2])
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns a breakdown of application nationalities within 'sept_oct' window" do
+ expect(kpis.nationality_breakdown).to contain_exactly(["Nationality 1", 3], ["Nationality 2", 1])
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns a breakdown of application nationalities within 'jan_feb' window" do
+ expect(kpis.nationality_breakdown).to contain_exactly(["Nationality 3", 2])
+ end
+ end
+ end
+
+ describe "#gender_breakdown" do
+ before do
+ create_list(:application, 3, applicant: create(:applicant, sex: "male"), created_at: Date.new(2023, 9, 15))
+ create(:application, applicant: create(:applicant, sex: "female"), created_at: Date.new(2023, 9, 15))
+ create(:application, applicant: create(:applicant, sex: "female"), created_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns a breakdown of all application genders" do
+ expect(kpis.gender_breakdown).to contain_exactly(["male", 3], ["female", 2])
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns a breakdown of application genders within 'sept_oct' window" do
+ expect(kpis.gender_breakdown).to contain_exactly(["male", 3], ["female", 1])
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns a breakdown of application genders within 'jan_feb' window" do
+ expect(kpis.gender_breakdown).to contain_exactly(["female", 1])
+ end
+ end
+ end
+
+ describe "#rejection_reason_breakdown" do
+ before do
+ applicant = create(:applicant)
+ create_list(:application_progress, 2, application: create(:application, applicant: applicant, created_at: Date.new(2023, 9, 15)), rejection_reason: "suspected_fraud")
+ create(:application_progress, application: create(:application, applicant: applicant, created_at: Date.new(2023, 9, 15)), rejection_reason: "ineligible_school")
+ create(:application_progress, application: create(:application, applicant: applicant, created_at: Date.new(2024, 1, 15)), rejection_reason: "ineligible_school")
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns a breakdown of all application rejection reasons" do
+ expect(kpis.rejection_reason_breakdown).to contain_exactly(["suspected_fraud", 2], ["ineligible_school", 2])
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns a breakdown of application rejection reasons within 'sept_oct' window" do
+ expect(kpis.rejection_reason_breakdown).to contain_exactly(["suspected_fraud", 2], ["ineligible_school", 1])
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns a breakdown of application rejection reasons within 'jan_feb' window" do
+ expect(kpis.rejection_reason_breakdown).to contain_exactly(["ineligible_school", 1])
+ end
+ end
+ end
+
+ describe "#time_to_initial_checks" do
+ before do
+ create(:application_progress, :initial_checks_completed,
+ application: create(:application, created_at: Date.new(2023, 9, 10)),
+ created_at: Date.new(2023, 9, 10),
+ initial_checks_completed_at: Date.new(2023, 9, 15))
+
+ create(:application_progress, :initial_checks_completed,
+ application: create(:application, created_at: Date.new(2023, 9, 10)),
+ created_at: Date.new(2023, 9, 10),
+ initial_checks_completed_at: Date.new(2023, 9, 15))
+
+ create(:application_progress, :initial_checks_completed,
+ application: create(:application, created_at: Date.new(2024, 1, 10)),
+ created_at: Date.new(2024, 1, 10),
+ initial_checks_completed_at: Date.new(2024, 1, 15))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns min, max and average time to initial checks for all applications" do
+ result = kpis.time_to_initial_checks
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "5 days"
+ expect(result[:average]).to eq "5 days"
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns min, max and average time to initial checks for applications in 'sept_oct' window" do
+ result = kpis.time_to_initial_checks
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "5 days"
+ expect(result[:average]).to eq "5 days"
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns min, max and average time to initial checks for applications in 'jan_feb' window" do
+ result = kpis.time_to_initial_checks
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "5 days"
+ expect(result[:average]).to eq "5 days"
+ end
+ end
+ end
+
+ describe "#time_to_home_office_checks" do
+ before do
+ create(:application_progress, :home_office_checks_completed,
+ application: create(:application, created_at: Date.new(2023, 9, 10)),
+ created_at: Date.new(2023, 9, 10),
+ initial_checks_completed_at: Date.new(2023, 9, 15),
+ home_office_checks_completed_at: Date.new(2023, 9, 21))
+
+ create(:application_progress, :home_office_checks_completed,
+ application: create(:application, created_at: Date.new(2023, 9, 10)),
+ created_at: Date.new(2023, 9, 10),
+ initial_checks_completed_at: Date.new(2023, 9, 15),
+ home_office_checks_completed_at: Date.new(2023, 9, 25))
+
+ create(:application_progress, :home_office_checks_completed,
+ application: create(:application, created_at: Date.new(2024, 1, 10)),
+ created_at: Date.new(2024, 1, 10),
+ initial_checks_completed_at: Date.new(2024, 1, 15),
+ home_office_checks_completed_at: Date.new(2024, 1, 20))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns min, max and average time to home office checks for all applications" do
+ result = kpis.time_to_home_office_checks
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "7 days"
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns min, max and average time to home office checks for applications in 'sept_oct' window" do
+ result = kpis.time_to_home_office_checks
+
+ expect(result[:min]).to eq "6 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "8 days"
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns min, max and average time to home office checks for applications in 'jan_feb' window" do
+ result = kpis.time_to_home_office_checks
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "5 days"
+ expect(result[:average]).to eq "5 days"
+ end
+ end
+ end
+
+ describe "#time_to_school_checks" do
+ before do
+ create(:application_progress, :school_checks_completed,
+ application: create(:application, created_at: Date.new(2023, 9, 10)),
+ created_at: Date.new(2023, 9, 10),
+ home_office_checks_completed_at: Date.new(2023, 9, 15),
+ school_checks_completed_at: Date.new(2023, 9, 20))
+
+ create(:application_progress, :school_checks_completed,
+ application: create(:application, created_at: Date.new(2023, 9, 10)),
+ created_at: Date.new(2023, 9, 10),
+ home_office_checks_completed_at: Date.new(2023, 9, 15),
+ school_checks_completed_at: Date.new(2023, 9, 25))
+
+ create(:application_progress, :school_checks_completed,
+ application: create(:application, created_at: Date.new(2024, 1, 10)),
+ created_at: Date.new(2024, 1, 10),
+ home_office_checks_completed_at: Date.new(2024, 1, 15),
+ school_checks_completed_at: Date.new(2024, 1, 25))
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns min, max and average time to school checks for all applications" do
+ result = kpis.time_to_school_checks
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "8 days"
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns min, max and average time to school checks for applications in 'sept_oct' window" do
+ result = kpis.time_to_school_checks
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "8 days"
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns min, max and average time to school checks for applications in 'jan_feb' window" do
+ result = kpis.time_to_school_checks
+
+ expect(result[:min]).to eq "10 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "10 days"
+ end
+ end
+ end
+
+ describe "#time_to_banking_approval" do
+ before do
+ sept_oct_school_check = Date.new(2023, 9, 27)
+ jan_feb_school_check = Date.new(2024, 1, 20)
+
+ create(:application_progress, :banking_approval_completed,
+ application: create(:application, created_at: sept_oct_school_check),
+ created_at: sept_oct_school_check,
+ school_checks_completed_at: sept_oct_school_check,
+ banking_approval_completed_at: sept_oct_school_check + 5.days)
+
+ create(:application_progress, :banking_approval_completed,
+ application: create(:application, created_at: sept_oct_school_check),
+ created_at: sept_oct_school_check,
+ school_checks_completed_at: sept_oct_school_check,
+ banking_approval_completed_at: sept_oct_school_check + 7.days)
+
+ create(:application_progress, :banking_approval_completed,
+ application: create(:application, created_at: jan_feb_school_check),
+ created_at: jan_feb_school_check,
+ school_checks_completed_at: jan_feb_school_check,
+ banking_approval_completed_at: jan_feb_school_check + 10.days)
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns min, max and average time to banking approval for all applications" do
+ result = kpis.time_to_banking_approval
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "7 days"
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns min, max and average time to banking approval for applications in 'sept_oct' window" do
+ result = kpis.time_to_banking_approval
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "7 days"
+ expect(result[:average]).to eq "6 days"
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns min, max and average time to banking approval for applications in 'jan_feb'" do
+ result = kpis.time_to_banking_approval
+
+ expect(result[:min]).to eq "10 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "10 days"
+ end
+ end
+ end
+
+ describe "#time_to_payment_confirmation" do
+ before do
+ sept_oct_banking_approval = Date.new(2023, 9, 27)
+ jan_feb_banking_approval = Date.new(2024, 1, 20)
+
+ create(:application_progress, :payment_confirmation_completed,
+ application: create(:application, created_at: sept_oct_banking_approval),
+ created_at: sept_oct_banking_approval,
+ banking_approval_completed_at: sept_oct_banking_approval,
+ payment_confirmation_completed_at: sept_oct_banking_approval + 5.days)
+
+ create(:application_progress, :payment_confirmation_completed,
+ application: create(:application, created_at: sept_oct_banking_approval),
+ created_at: sept_oct_banking_approval,
+ banking_approval_completed_at: sept_oct_banking_approval,
+ payment_confirmation_completed_at: sept_oct_banking_approval + 7.days)
+
+ create(:application_progress, :payment_confirmation_completed,
+ application: create(:application, created_at: jan_feb_banking_approval),
+ created_at: jan_feb_banking_approval,
+ banking_approval_completed_at: jan_feb_banking_approval,
+ payment_confirmation_completed_at: jan_feb_banking_approval + 10.days)
+ end
+
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ it "returns min, max and average time to payment confirmation for all applications" do
+ result = kpis.time_to_payment_confirmation
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "7 days"
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ it "returns min, max and average time to payment confirmation for applications in 'sept_oct' window" do
+ result = kpis.time_to_payment_confirmation
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "7 days"
+ expect(result[:average]).to eq "6 days"
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ it "returns min, max and average time to payment confirmation for applications in 'jan_feb' window" do
+ result = kpis.time_to_payment_confirmation
+
+ expect(result[:min]).to eq "10 days"
+ expect(result[:max]).to eq "10 days"
+ expect(result[:average]).to eq "10 days"
+ end
+ end
+ end
+
+ describe "#status_breakdown" do
+ context "when window is 'all'" do
+ subject(:kpis) { described_class.new(window: "all") }
+
+ before do
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: Date.new(2023, 9, 10))
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ created_at: Date.new(2024, 1, 5))
+ end
+
+ let(:expected_breakdown) do
+ {
+ "initial_checks" => 0,
+ "home_office_checks" => 1,
+ "school_checks" => 1,
+ "bank_approval" => 0,
+ "payment_confirmation" => 0,
+ "paid" => 0,
+ "rejected" => 0,
+ }
+ end
+
+ it "returns the ordered application status breakdown" do
+ result = kpis.status_breakdown
- it { expect(kpis.total_paid).to eq(5) }
+ expect(result).to include(expected_breakdown)
+ end
+ end
+
+ context "when window is 'sept_oct'" do
+ subject(:kpis) { described_class.new(window: "sept_oct") }
+
+ before do
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: Date.new(2023, 9, 10))
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ created_at: Date.new(2024, 1, 5))
+ end
+
+ let(:expected_breakdown) do
+ {
+ "initial_checks" => 0,
+ "home_office_checks" => 1,
+ "school_checks" => 0,
+ "bank_approval" => 0,
+ "payment_confirmation" => 0,
+ "paid" => 0,
+ "rejected" => 0,
+ }
+ end
+
+ it "returns the ordered application status breakdown for applications in 'sept_oct' window" do
+ result = kpis.status_breakdown
+
+ expect(result).to include(expected_breakdown)
+ end
+ end
+
+ context "when window is 'jan_feb'" do
+ subject(:kpis) { described_class.new(window: "jan_feb") }
+
+ before do
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: Date.new(2023, 9, 10))
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ created_at: Date.new(2024, 1, 5))
+ end
+
+ let(:expected_breakdown) do
+ {
+ "initial_checks" => 0,
+ "home_office_checks" => 0,
+ "school_checks" => 1,
+ "bank_approval" => 0,
+ "payment_confirmation" => 0,
+ "paid" => 0,
+ "rejected" => 0,
+ }
+ end
+
+ it "returns the ordered application status breakdown for applications in 'jan_feb' window" do
+ result = kpis.status_breakdown
+
+ expect(result).to include(expected_breakdown)
+ end
+ end
end
describe "funnel_date_range_title" do
diff --git a/spec/models/summary_spec.rb b/spec/models/summary_spec.rb
index 21ed3d04..83558eab 100644
--- a/spec/models/summary_spec.rb
+++ b/spec/models/summary_spec.rb
@@ -51,7 +51,7 @@
value: { text: "Yes" },
actions: [{ href: "/step/contract-details", visually_hidden_text: "contract details" }] },
{ key: { text: "Contract start date" },
- value: { text: "01-09-2023" },
+ value: { text: "01-09-2024" },
actions: [{ href: "/step/start-date", visually_hidden_text: "start date" }] },
{ key: { text: "Subject" },
value: { text: "Physics" },
@@ -60,7 +60,7 @@
value: { text: "British National (Overseas) visa" },
actions: [{ href: "/step/visa", visually_hidden_text: "visa" }] },
{ key: { text: "Date of entry" },
- value: { text: "01-09-2023" },
+ value: { text: "01-09-2024" },
actions: [{ href: "/step/entry-date", visually_hidden_text: "entry date" }] },
]
end
diff --git a/spec/queries/time_to_banking_approval_query_spec.rb b/spec/queries/time_to_banking_approval_query_spec.rb
index 6a4a6d82..00038e24 100644
--- a/spec/queries/time_to_banking_approval_query_spec.rb
+++ b/spec/queries/time_to_banking_approval_query_spec.rb
@@ -2,21 +2,44 @@
RSpec.describe TimeToBankingApprovalQuery, type: :model do
describe "#call" do
- before do
- create(:application_progress, :banking_approval_completed, application: build(:application),
- school_checks_completed_at: 10.days.ago, banking_approval_completed_at: 5.days.ago)
- create(:application_progress, :banking_approval_completed, application: build(:application),
- school_checks_completed_at: 20.days.ago, banking_approval_completed_at: 10.days.ago)
- create(:application_progress, :banking_approval_completed, application: build(:application),
- school_checks_completed_at: 30.days.ago, banking_approval_completed_at: 15.days.ago)
+ context "with various days taken for banking approval" do
+ before do
+ create(:application_progress, :banking_approval_completed,
+ application: build(:application),
+ school_checks_completed_at: 10.days.ago, banking_approval_completed_at: 5.days.ago)
+ create(:application_progress, :banking_approval_completed,
+ application: build(:application),
+ school_checks_completed_at: 20.days.ago, banking_approval_completed_at: 10.days.ago)
+ create(:application_progress, :banking_approval_completed,
+ application: build(:application),
+ school_checks_completed_at: 30.days.ago, banking_approval_completed_at: 15.days.ago)
+ end
+
+ it "returns min, max and average time in days" do
+ result = described_class.new.call
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "15 days"
+ expect(result[:average]).to eq "10 days"
+ end
end
- it "returns min, max and average time in days" do
- result = described_class.new.call
+ context "with banking approval completed within a day" do
+ before do
+ create(:application_progress, :banking_approval_completed,
+ application: build(:application),
+ school_checks_completed_at: 0.days.ago, banking_approval_completed_at: 0.days.ago)
+
+ create(:application_progress, :banking_approval_completed,
+ application: build(:application),
+ school_checks_completed_at: 1.day.ago, banking_approval_completed_at: 0.days.ago)
+ end
- expect(result[:min]).to eq "5 days"
- expect(result[:max]).to eq "15 days"
- expect(result[:average]).to eq "10 days"
+ it "returns correct pluralization for 0 days and 1 day" do
+ result = described_class.new.call
+ expect(result[:min]).to eq "0 days"
+ expect(result[:max]).to eq "1 day"
+ end
end
end
end
diff --git a/spec/queries/time_to_home_office_checks_query_spec.rb b/spec/queries/time_to_home_office_checks_query_spec.rb
index 7d42499a..8051359a 100644
--- a/spec/queries/time_to_home_office_checks_query_spec.rb
+++ b/spec/queries/time_to_home_office_checks_query_spec.rb
@@ -2,21 +2,44 @@
RSpec.describe TimeToHomeOfficeChecksQuery, type: :model do
describe "#call" do
- before do
- create(:application_progress, :home_office_checks_completed, application: build(:application),
- initial_checks_completed_at: 10.days.ago, home_office_checks_completed_at: 5.days.ago)
- create(:application_progress, :home_office_checks_completed, application: build(:application),
- initial_checks_completed_at: 20.days.ago, home_office_checks_completed_at: 10.days.ago)
- create(:application_progress, :home_office_checks_completed, application: build(:application),
- initial_checks_completed_at: 30.days.ago, home_office_checks_completed_at: 15.days.ago)
+ context "with various days taken for home office checks" do
+ before do
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ initial_checks_completed_at: 10.days.ago, home_office_checks_completed_at: 5.days.ago)
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ initial_checks_completed_at: 20.days.ago, home_office_checks_completed_at: 10.days.ago)
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ initial_checks_completed_at: 30.days.ago, home_office_checks_completed_at: 15.days.ago)
+ end
+
+ it "returns min, max and average time in days" do
+ result = described_class.new.call
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "15 days"
+ expect(result[:average]).to eq "10 days"
+ end
end
- it "returns min, max and average time in days" do
- result = described_class.new.call
+ context "with home office checks completed within a day" do
+ before do
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ initial_checks_completed_at: 0.days.ago, home_office_checks_completed_at: 0.days.ago)
+ create(:application_progress, :home_office_checks_completed,
+ application: build(:application),
+ initial_checks_completed_at: 1.day.ago, home_office_checks_completed_at: 0.days.ago)
+ end
- expect(result[:min]).to eq "5 days"
- expect(result[:max]).to eq "15 days"
- expect(result[:average]).to eq "10 days"
+ it "returns correct pluralization for 0 days and 1 day" do
+ result = described_class.new.call
+ expect(result[:min]).to eq "0 days"
+ expect(result[:average]).to eq "1 day"
+ expect(result[:max]).to eq "1 day"
+ end
end
end
end
diff --git a/spec/queries/time_to_initial_checks_query_spec.rb b/spec/queries/time_to_initial_checks_query_spec.rb
index 8f69d2bb..9c55885b 100644
--- a/spec/queries/time_to_initial_checks_query_spec.rb
+++ b/spec/queries/time_to_initial_checks_query_spec.rb
@@ -2,21 +2,43 @@
RSpec.describe TimeToInitialChecksQuery, type: :model do
describe "#call" do
- before do
- create(:application_progress, :initial_checks_completed, application: build(:application),
- created_at: 10.days.ago, initial_checks_completed_at: 5.days.ago)
- create(:application_progress, :initial_checks_completed, application: build(:application),
- created_at: 20.days.ago, initial_checks_completed_at: 10.days.ago)
- create(:application_progress, :initial_checks_completed, application: build(:application),
- created_at: 30.days.ago, initial_checks_completed_at: 15.days.ago)
+ context "with various days taken for initial query checks" do
+ before do
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: 10.days.ago, initial_checks_completed_at: 5.days.ago)
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: 20.days.ago, initial_checks_completed_at: 10.days.ago)
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: 30.days.ago, initial_checks_completed_at: 15.days.ago)
+ end
+
+ it "returns min, max and average time in days" do
+ result = described_class.new.call
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "15 days"
+ expect(result[:average]).to eq "10 days"
+ end
end
- it "returns min, max and average time in days" do
- result = described_class.new.call
+ context "with initial checks completed within a day" do
+ before do
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: 0.days.ago, initial_checks_completed_at: 0.days.ago)
+ create(:application_progress, :initial_checks_completed,
+ application: build(:application),
+ created_at: 1.day.ago, initial_checks_completed_at: 0.days.ago)
+ end
- expect(result[:min]).to eq "5 days"
- expect(result[:max]).to eq "15 days"
- expect(result[:average]).to eq "10 days"
+ it "returns correct pluralization for 0 days and 1 day" do
+ result = described_class.new.call
+ expect(result[:min]).to eq "0 days"
+ expect(result[:max]).to eq "1 day"
+ end
end
end
end
diff --git a/spec/queries/time_to_payment_confirmation_query_spec.rb b/spec/queries/time_to_payment_confirmation_query_spec.rb
index de6efe4b..327b741a 100644
--- a/spec/queries/time_to_payment_confirmation_query_spec.rb
+++ b/spec/queries/time_to_payment_confirmation_query_spec.rb
@@ -2,21 +2,43 @@
RSpec.describe TimeToPaymentConfirmationQuery, type: :model do
describe "#call" do
- before do
- create(:application_progress, :payment_confirmation_completed, application: build(:application),
- banking_approval_completed_at: 10.days.ago, payment_confirmation_completed_at: 5.days.ago)
- create(:application_progress, :payment_confirmation_completed, application: build(:application),
- banking_approval_completed_at: 20.days.ago, payment_confirmation_completed_at: 10.days.ago)
- create(:application_progress, :payment_confirmation_completed, application: build(:application),
- banking_approval_completed_at: 30.days.ago, payment_confirmation_completed_at: 15.days.ago)
+ context "with various days taken for payment confirmation" do
+ before do
+ create(:application_progress, :payment_confirmation_completed,
+ application: build(:application),
+ banking_approval_completed_at: 10.days.ago, payment_confirmation_completed_at: 5.days.ago)
+ create(:application_progress, :payment_confirmation_completed,
+ application: build(:application),
+ banking_approval_completed_at: 20.days.ago, payment_confirmation_completed_at: 10.days.ago)
+ create(:application_progress, :payment_confirmation_completed,
+ application: build(:application),
+ banking_approval_completed_at: 30.days.ago, payment_confirmation_completed_at: 15.days.ago)
+ end
+
+ it "returns min, max and average time in days" do
+ result = described_class.new.call
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "15 days"
+ expect(result[:average]).to eq "10 days"
+ end
end
- it "returns min, max and average time in days" do
- result = described_class.new.call
+ context "with payment confirmation completed within a day" do
+ before do
+ create(:application_progress, :payment_confirmation_completed,
+ application: build(:application),
+ banking_approval_completed_at: 0.days.ago, payment_confirmation_completed_at: 0.days.ago)
+ create(:application_progress, :payment_confirmation_completed,
+ application: build(:application),
+ banking_approval_completed_at: 1.day.ago, payment_confirmation_completed_at: 0.days.ago)
+ end
- expect(result[:min]).to eq "5 days"
- expect(result[:max]).to eq "15 days"
- expect(result[:average]).to eq "10 days"
+ it "returns correct pluralization for 0 days and 1 day" do
+ result = described_class.new.call
+ expect(result[:min]).to eq "0 days"
+ expect(result[:max]).to eq "1 day"
+ end
end
end
end
diff --git a/spec/queries/time_to_school_checks_query_spec.rb b/spec/queries/time_to_school_checks_query_spec.rb
index 7822503a..e5a498aa 100644
--- a/spec/queries/time_to_school_checks_query_spec.rb
+++ b/spec/queries/time_to_school_checks_query_spec.rb
@@ -2,21 +2,43 @@
RSpec.describe TimeToSchoolChecksQuery, type: :model do
describe "#call" do
- before do
- create(:application_progress, :school_checks_completed, application: build(:application),
- home_office_checks_completed_at: 10.days.ago, school_checks_completed_at: 5.days.ago)
- create(:application_progress, :school_checks_completed, application: build(:application),
- home_office_checks_completed_at: 20.days.ago, school_checks_completed_at: 10.days.ago)
- create(:application_progress, :school_checks_completed, application: build(:application),
- home_office_checks_completed_at: 30.days.ago, school_checks_completed_at: 15.days.ago)
+ context "with various days taken for school checks" do
+ before do
+ create(:application_progress, :school_checks_completed,
+ application: build(:application),
+ home_office_checks_completed_at: 10.days.ago, school_checks_completed_at: 5.days.ago)
+ create(:application_progress, :school_checks_completed,
+ application: build(:application),
+ home_office_checks_completed_at: 20.days.ago, school_checks_completed_at: 10.days.ago)
+ create(:application_progress, :school_checks_completed,
+ application: build(:application),
+ home_office_checks_completed_at: 30.days.ago, school_checks_completed_at: 15.days.ago)
+ end
+
+ it "returns min, max and average time in days" do
+ result = described_class.new.call
+
+ expect(result[:min]).to eq "5 days"
+ expect(result[:max]).to eq "15 days"
+ expect(result[:average]).to eq "10 days"
+ end
end
- it "returns min, max and average time in days" do
- result = described_class.new.call
+ context "with school checks completed within a day" do
+ before do
+ create(:application_progress, :school_checks_completed,
+ application: build(:application),
+ home_office_checks_completed_at: 0.days.ago, school_checks_completed_at: 0.days.ago)
+ create(:application_progress, :school_checks_completed,
+ application: build(:application),
+ home_office_checks_completed_at: 1.day.ago, school_checks_completed_at: 0.days.ago)
+ end
- expect(result[:min]).to eq "5 days"
- expect(result[:max]).to eq "15 days"
- expect(result[:average]).to eq "10 days"
+ it "returns correct pluralization for 0 days and 1 day" do
+ result = described_class.new.call
+ expect(result[:min]).to eq "0 days"
+ expect(result[:max]).to eq "1 day"
+ end
end
end
end
diff --git a/spec/support/application_form_steps.rb b/spec/support/application_form_steps.rb
index ebdea7d9..d687f956 100644
--- a/spec/support/application_form_steps.rb
+++ b/spec/support/application_form_steps.rb
@@ -52,9 +52,7 @@ def and_i_select_my_visa_type
def and_i_enter_my_entry_date(route)
assert_i_am_in_the_entry_date_question(route)
- fill_in("Day", with: 12)
- fill_in("Month", with: 6)
- fill_in("Year", with: 2023)
+ fill_in_date
click_button("Continue")
end
@@ -114,9 +112,7 @@ def choose_no
def and_i_enter_my_contract_start_date
assert_i_am_in_the_contract_start_date_question
- fill_in("Day", with: 12)
- fill_in("Month", with: 7)
- fill_in("Year", with: 2023)
+ fill_in_date
click_button("Continue")
end
@@ -139,3 +135,11 @@ def and_i_enter_an_invalid_date
click_button("Continue")
end
end
+
+def fill_in_date
+ three_months_ago = Time.zone.today - 3.months
+
+ fill_in("Day", with: three_months_ago.day)
+ fill_in("Month", with: three_months_ago.month)
+ fill_in("Year", with: three_months_ago.year)
+end