From 46ee9988def0b1d7fd6ad55831c7d42b05ddf769 Mon Sep 17 00:00:00 2001
From: Ash Davies <3853061+DrizzlyOwl@users.noreply.github.com>
Date: Thu, 26 Oct 2023 15:08:32 +0100
Subject: [PATCH] Fix invalid function argument error

* When a CI Storage container isn't deployed, Terraform throws an 'Invalid value for "value" parameter: the given value is not sensitive, so this call is redundant.' error. Moving the 'nonsensitive' function call to inside the conditional check fixes this
---
 terraform/ci-storage.tf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/terraform/ci-storage.tf b/terraform/ci-storage.tf
index 94471b5e0..809f5a95b 100644
--- a/terraform/ci-storage.tf
+++ b/terraform/ci-storage.tf
@@ -61,5 +61,5 @@ data "azurerm_storage_account_blob_container_sas" "ci-test-reports" {
 
 output "ci-test-reports-storage-sas-url" {
   description = "A SAS tokenised URL for accessing the CI Reports in the Blob Storage Container"
-  value       = nonsensitive(local.enable_ci_report_storage_container ? "${azurerm_storage_account.ci-test-reports[0].primary_blob_endpoint}${azurerm_storage_container.ci-test-reports[0].name}${data.azurerm_storage_account_blob_container_sas.ci-test-reports[0].sas}" : null)
+  value       = local.enable_ci_report_storage_container ? nonsensitive("${azurerm_storage_account.ci-test-reports[0].primary_blob_endpoint}${azurerm_storage_container.ci-test-reports[0].name}${data.azurerm_storage_account_blob_container_sas.ci-test-reports[0].sas}") : null
 }