From 33bd6a24507efe98c001d1069fcefedf33ffe8cb Mon Sep 17 00:00:00 2001 From: Katherine Martin <78093815+martikat@users.noreply.github.com> Date: Fri, 26 Apr 2024 09:26:50 +0100 Subject: [PATCH] Update based on PR comments --- app/assets/stylesheets/hfeyp-v2.scss | 1 + app/views/layouts/application.html.slim | 10 +++++++--- app/views/pages/side_nav.slim | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/app/assets/stylesheets/hfeyp-v2.scss b/app/assets/stylesheets/hfeyp-v2.scss index e8f6cac6..c368ec09 100644 --- a/app/assets/stylesheets/hfeyp-v2.scss +++ b/app/assets/stylesheets/hfeyp-v2.scss @@ -204,6 +204,7 @@ a:hover .hf-card-container .hf-card-details h3 { .mob-section { background: #f1f2f350; margin-top: -20px; + margin-bottom: 20px; padding: 20px 15px 0px; border-bottom: 1px solid #ccc; } diff --git a/app/views/layouts/application.html.slim b/app/views/layouts/application.html.slim index 14abd4b9..9c5446f4 100644 --- a/app/views/layouts/application.html.slim +++ b/app/views/layouts/application.html.slim @@ -37,11 +37,15 @@ html.govuk-template lang='en' = navigation - .dfe-content-page--header class='govuk-!-padding-bottom-7' - .dfe-width-container + - if page.nil? + .dfe-width-container = render 'layouts/banner' - = yield :hero + - else + .dfe-content-page--header class='govuk-!-padding-bottom-7' + .dfe-width-container + = render 'layouts/banner' + = yield :hero .dfe-width-container main#main-content.govuk-main-wrapper role='main' diff --git a/app/views/pages/side_nav.slim b/app/views/pages/side_nav.slim index e9ccd360..0e1397a8 100644 --- a/app/views/pages/side_nav.slim +++ b/app/views/pages/side_nav.slim @@ -5,7 +5,7 @@ = render partial: 'hero', locals: { hero: page.hero } .govuk-grid-row - .govuk-grid-column-one-quarter.sticky.mob-section class='govuk-!-margin-bottom-4' + .govuk-grid-column-one-quarter.sticky.mob-section input#menu-icon-chk.menu-btn[type="checkbox" name="menu-icon" checked] label.menu-icon.govuk-body-l[for="menu-icon-chk"] svg[xmlns="http://www.w3.org/2000/svg" height="1em" viewbox="0 0 448 512"]